[vcpkg] Add policy VCPKG_POLICY_SKIP_DUMPBIN_CHECKS#9901
Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom Feb 6, 2020
Merged
[vcpkg] Add policy VCPKG_POLICY_SKIP_DUMPBIN_CHECKS#9901ras0219-msft merged 3 commits intomicrosoft:masterfrom
ras0219-msft merged 3 commits intomicrosoft:masterfrom
Conversation
and correct some cmake advices.
Paths should always be handled with "${PATH}" due to possible spaces
vicroms
requested changes
Feb 4, 2020
ras0219-msft
requested changes
Feb 5, 2020
Contributor
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
LGTM once comments are addressed.
toolsrc/src/vcpkg/postbuildlint.cpp
Outdated
| "Include files should not be duplicated into the /debug/include directory. If this cannot " | ||
| "be disabled in the project cmake, use\n" | ||
| " file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)\n"); | ||
| " file(REMOVE_RECURSE \"${CURRENT_PACKAGES_DIR}/debug/include)\"\n"); |
Contributor
There was a problem hiding this comment.
The close quote is in the wrong place; should be before the close paren.
and change copyright copy to use configure_file
vicroms
approved these changes
Feb 5, 2020
Member
|
/azp run |
PhoebeHui
added
the
info:needs-maintainer-attention
Contributor
|
LGTM, thanks! |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
[vcpkg] Add policy VCPKG_POLICY_SKIP_DUMPBIN_CHECKS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also corrects some cmake advices. Paths should always be handled with "${PATH}" due to possible spaces
allows users/ports to skip the dumpbin check if necessary, e.g. if dumpbin simply fails on the compiled dll or for other reasons