Skip to content

[vcpkg] use _INIT flags in windows toolchain just like in the other toolchains#9862

Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom
Neumann-A:use_init_flags_windows_toolchain
Mar 25, 2020
Merged

[vcpkg] use _INIT flags in windows toolchain just like in the other toolchains#9862
dan-shaw merged 1 commit intomicrosoft:masterfrom
Neumann-A:use_init_flags_windows_toolchain

Conversation

@Neumann-A
Copy link
Copy Markdown
Contributor

closes #9853

@Neumann-A
Copy link
Copy Markdown
Contributor Author

HMm maybe it is better to stuff everything in VCPKG_(C|CXX)_FLAGS and then move it into the _INIT vars. This way other buildsystem than cmake can also leverage on VCPKG_(C|CXX)_FLAGS

Copy link
Copy Markdown
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan-shaw dan-shaw added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed needs-feature-review labels Mar 20, 2020
@dan-shaw dan-shaw merged commit da0a154 into microsoft:master Mar 25, 2020
JackBoosY pushed a commit to JackBoosY/vcpkg that referenced this pull request Mar 26, 2020
@cenit
Copy link
Copy Markdown
Contributor

cenit commented Mar 26, 2020

@dan-shaw isn't it better to trigger a full rebuild before accepting toolchain changes?

@Neumann-A Neumann-A deleted the use_init_flags_windows_toolchain branch March 26, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[toolchains] make windows.cmake consistent with other toolchains

5 participants