Skip to content

[open62541] Update to v1.0#9767

Merged
vicroms merged 7 commits intomicrosoft:masterfrom
yurybura:open62541
Jan 21, 2020
Merged

[open62541] Update to v1.0#9767
vicroms merged 7 commits intomicrosoft:masterfrom
yurybura:open62541

Conversation

@yurybura
Copy link
Contributor

@yurybura yurybura commented Jan 20, 2020

[open62541] Update to v1.0

Fixes #9766

@traversaro
Copy link
Contributor

traversaro commented Jan 20, 2020 •
edited
Loading

Thanks @yurybura for working on this.

As the dependency on python six was dropped in open62541/open62541#2493 , I guess we can now also remove all the code necessary to install six, see https://github.com/microsoft/vcpkg/pull/9767/files#diff-d7c83a3acc5f48906322217e14675fe7L36 .

@yurybura
Copy link
Contributor Author

yurybura commented Jan 20, 2020

Hi @traversaro
Thanks for comment. Unfortunately your link is unavailable. I'll try to remove python-six after my investigations.

@traversaro
Copy link
Contributor

traversaro commented Jan 20, 2020 •
edited
Loading

Hi @traversaro
Thanks for comment. Unfortunately your link is unavailable. I'll try to remove python-six after my investigations.

Sorry, I had copy pasted the wrong link. The correct one is open62541/open62541#2493 .

@yurybura
Copy link
Contributor Author

yurybura commented Jan 20, 2020

Requires #9752 merge to fix Windows CI...

cenit
cenit reviewed Jan 20, 2020
View reviewed changes
@yurybura yurybura marked this pull request as ready for review January 20, 2020 21:26
NancyLi1013
NancyLi1013 suggested changes Jan 21, 2020
View reviewed changes
@yurybura
Copy link
Contributor Author

yurybura commented Jan 21, 2020

@NancyLi1013 thank you for review! I've fixed issues.

@NancyLi1013 NancyLi1013 requested a review from JackBoosY January 21, 2020 05:39
JackBoosY
JackBoosY suggested changes Jan 21, 2020
View reviewed changes
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Jan 21, 2020
@vicroms
Copy link
Member

vicroms commented Jan 21, 2020

Thanks @yurybura for the PR and everyone that helped review it!

@vicroms vicroms merged commit 127d497 into microsoft:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@cenit cenit cenit left review comments

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[open62541] update to 1.0

6 participants

@yurybura @traversaro @vicroms @cenit @NancyLi1013 @JackBoosY