[paho-mqtt] Fix Windows platform predefined macros#9753
Merged
vicroms merged 2 commits intomicrosoft:masterfrom Jan 22, 2020
Merged
[paho-mqtt] Fix Windows platform predefined macros#9753vicroms merged 2 commits intomicrosoft:masterfrom
vicroms merged 2 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
Regressions will fixed in #9752. |
PhoebeHui
approved these changes
Jan 19, 2020
Contributor
|
The following code in #if defined(_WIN32) || defined(_WIN64)
The preprocessor macro
So, the following is sufficient (supported by MSVC, GCC, clang): #if defined(_WIN32)
|
Contributor
Author
|
@c72578 Well, I do this because I want to be as consistent as possible with the source code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to msdn documentation, fix predefined
WIN32andWIN64.Related: #9742.