[freeglut] check whether debug/release is enabled before moving files#9745
Merged
vicroms merged 1 commit intomicrosoft:masterfrom Jan 30, 2020
Merged
[freeglut] check whether debug/release is enabled before moving files#9745vicroms merged 1 commit intomicrosoft:masterfrom
vicroms merged 1 commit intomicrosoft:masterfrom
Conversation
JackBoosY
suggested changes
Jan 19, 2020
Contributor
JackBoosY
left a comment
JackBoosY
left a comment
There was a problem hiding this comment.
Can you update version in file CONTROL?
See documentation.
Contributor
Author
|
Hi @JackBoos, just to be sure I should update the control file to indicate that I have patched the port right ? (i.e. -1) |
Contributor
|
@theblackunknown You should change it to |
theblackunknown
force-pushed
the
freeglut
branch
from
edcff9b to
029636d
Compare
Contributor
Author
|
@JackBoosY PR updated |
JackBoosY
approved these changes
Jan 20, 2020
Contributor
|
LGTM, thanks! |
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using custom triplet which request to only build debug or release flavor this ports fails
What does your PR fix?
It fixes the issue by checking what VCPKG has been asked to build
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?
Yes