[restclient-cpp] Fix portfile and update version.#9717
Merged
strega-nil merged 15 commits intomicrosoft:masterfrom May 11, 2020
Merged
[restclient-cpp] Fix portfile and update version.#9717strega-nil merged 15 commits intomicrosoft:masterfrom
strega-nil merged 15 commits intomicrosoft:masterfrom
Conversation
NancyLi1013
suggested changes
Jan 17, 2020
Contributor
|
Hi @et-nik Thanks for this PR. |
Update version Update handling copiright Remove no longer needed include Move COMPILE_TYPE parameter
Contributor
Author
|
Version changed in
|
Contributor
|
/azp run |
Contributor
Author
|
Hm. Now vcpkg-windows-PR-test failed |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9717 in repo microsoft/vcpkg |
Contributor
Author
|
@NancyLi1013 could you run tests again? |
Contributor
NancyLi1013
approved these changes
Jan 21, 2020
NancyLi1013
added
the
info:needs-maintainer-attention
vicroms
reviewed
Jan 22, 2020
vicroms
added
waiting for response
and removed
info:needs-maintainer-attention
maksqwe
reviewed
Jan 29, 2020
maksqwe
approved these changes
Feb 9, 2020
NancyLi1013
added
the
info:needs-maintainer-attention
dan-shaw
added
waiting for response
and removed
info:needs-maintainer-attention
Contributor
|
@et-nik |
Contributor
Author
|
Hello. I'll update this PR today. |
Contributor
|
It seems that the fix is not correct. Please refer to this doc to try it again. |
Contributor
Author
|
Done
|
NancyLi1013
reviewed
May 9, 2020
Contributor
Author
|
@NancyLi1013 Done Hm. I see that all checks are succeeded https://dev.azure.com/vcpkg/public/_build/results?buildId=36451&view=results But here check statuses are still "Waiting for..." |
Contributor
|
Cool, looks good to me! Thanks @et-nik :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR to update restclient library and fix portfile. Previously, the portfile had a command to delete the all compiled files (
restclient-cpp.lib,restclient-cppd.lib), it is mistake.I update library version from 0.5.1 tag to last commit. CMakeLists patches are no longer required in the new library version.
Library is updated and bugfixes, but the developer did not add new tags. Some people want tag updating (mrtazz/restclient-cpp#145).