Skip to content

Add autotools ports and fix libb2, libmagic for Mac#9648

Closed
SeekingMeaning wants to merge 4 commits intomicrosoft:masterfrom
SeekingMeaning:mac
Closed

Add autotools ports and fix libb2, libmagic for Mac#9648
SeekingMeaning wants to merge 4 commits intomicrosoft:masterfrom
SeekingMeaning:mac

Conversation

@SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Jan 13, 2020

Describe the pull request

  • What does your PR fix?
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    • Mac support only for autotools (autoconf, automake, libtool); yes
  • Does your PR follow the maintainer guide?
    • Yes (libb2 and libmagic require autotools on Mac, so I put them in this PR)

@SeekingMeaning SeekingMeaning marked this pull request as ready for review January 13, 2020 04:27
@JackBoosY
Copy link
Contributor

Thanks, we really need this PR.

@JackBoosY JackBoosY self-requested a review January 13, 2020 06:24
@SeekingMeaning
Copy link
Contributor Author

I just got libmagic working; should I push now?

@JackBoosY
Copy link
Contributor

@SeekingMeaning Yes please.

@cenit
Copy link
Contributor

cenit commented Jan 13, 2020

May I ask why is linux not included in your autotools compatibility baseline? It would be great also for other ports if it was available

@SeekingMeaning
Copy link
Contributor Author

@cenit Partly because I don't have a Linux machine 😛 but mostly because this PR is aimed towards getting CI fixed

@SeekingMeaning SeekingMeaning changed the title Add autotools ports and fix libb2 for Mac Add autotools ports and fix libb2, libmagic for Mac Jan 13, 2020
@SeekingMeaning
Copy link
Contributor Author

Closing this for now since CI works and the dependencies for this are kind of a mess.

@JackBoosY
Copy link
Contributor

Can I use your changes to create new ports autotools?

@SeekingMeaning
Copy link
Contributor Author

Yes, please do 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants