Skip to content

[doxygen] Updated to 1.8.17#9574

Merged
vicroms merged 4 commits intomicrosoft:masterfrom
tagsemb:master
Jan 16, 2020
Merged

[doxygen] Updated to 1.8.17#9574
vicroms merged 4 commits intomicrosoft:masterfrom
tagsemb:master

Conversation

@tagsemb
Copy link
Contributor

@tagsemb tagsemb commented Jan 7, 2020

Doxygen 1.8.15 was no longer available from doxygen.nl, updated to current version 1.8.17.

@c72578
Copy link
Contributor

c72578 commented Jan 7, 2020

Remark: doxygen files can also be downloaded from sourceforge in subfolders of
https://sourceforge.net/projects/doxygen/files/
e.g.:
https://sourceforge.net/projects/doxygen/files/rel-1.8.17/doxygen-1.8.17.windows.bin.zip

@JackBoosY JackBoosY requested a review from PhoebeHui January 8, 2020 03:04
@PhoebeHui PhoebeHui changed the title Updated doxygen to 1.8.17 from 1.8.15 [doxygen] Updated to 1.8.17 Jan 8, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui
Copy link
Contributor

/azp run

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 10, 2020
@c72578
Copy link
Contributor

c72578 commented Jan 10, 2020

@tagsemb maybe you want to work on a separate branch concerning fmt.
Otherwise the commits will appear here in this PR. In general, it is recommended to use a separate branch for each PR and not master.

@tagsemb
Copy link
Contributor Author

tagsemb commented Jan 10, 2020

@c72578 Oh I see, thank you, I was not aware.

@tagsemb
Copy link
Contributor Author

tagsemb commented Jan 10, 2020

@c72578 Any way I can/should clean up this mess, or is it enough that I don't make the same mistake in the future? I'm new to this, and I cannot find any option to remove commits from the PR now.

@dan-shaw
Copy link
Contributor

@tagsemb We squash the commits in the end so it should be okay if you add a commit to remove those changes. The fmt changes should be separate from the doxygen changes.

@tagsemb
Copy link
Contributor Author

tagsemb commented Jan 10, 2020

@dan-shaw Cheers, I've made a reverting commit to my master now that hopefully sets things right, and created a separate pull request on a separate branch for the fmt changes.

@strega-nil
Copy link
Contributor

/azp run

@vicroms
Copy link
Member

vicroms commented Jan 16, 2020

Thanks for the PR!

@vicroms vicroms merged commit 526f937 into microsoft:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants