Skip to content

[wpilib] update to 2020.1.1#9513

Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom
ThadHouse:wpilib2020
Jan 6, 2020
Merged

[wpilib] update to 2020.1.1#9513
dan-shaw merged 1 commit intomicrosoft:masterfrom
ThadHouse:wpilib2020

Conversation

@ThadHouse
Copy link
Contributor

@ThadHouse ThadHouse commented Dec 31, 2019

We released the initial 2020 release, so updates the port file to use that release

Only supports linux and windows. macOS is not supported, and never will be.

@JackBoosY JackBoosY requested a review from NancyLi1013 January 2, 2020 02:53
NancyLi1013
NancyLi1013 suggested changes Jan 2, 2020
View reviewed changes
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Jan 2, 2020 •
edited
Loading

Hi @ThadHouse thanks for this PR.
Since this port doesn't support macOS.
Could you please add this to portfie.cmake?

vcpkg_fail_port_install(ON_TARGET "OSX")

Also update ci.baseline.txt with wpilib:x64-osx=fail.

@ThadHouse
Copy link
Contributor Author

ThadHouse commented Jan 2, 2020

Fixed all the review comments.

NancyLi1013
NancyLi1013 suggested changes Jan 2, 2020
View reviewed changes
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 2, 2020

/azp run

@ThadHouse
Copy link
Contributor Author

ThadHouse commented Jan 2, 2020

Fixed. Would a separate PR be accepted for the formatting? I always have remove trailing whitespace set in my editor, and I'm sure other people do too, so it would be nice if that file was correct in that regard.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Jan 3, 2020

Hi @ThadHouse thanks for your attention about this.
As the doc described , we suggest that avoid trivial changes in untouched files.
Sorry for my last comments about the format. It's better to change it while you need to change other files. So we don't recommend a separate PR for the format.
You can update it in this PR if you‘re not afraid of trouble. Or you can change it next time if you would like.

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 3, 2020
@dan-shaw dan-shaw merged commit 9bd91cb into microsoft:master Jan 6, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 6, 2020

Thanks for the PR!

@SeekingMeaning SeekingMeaning mentioned this pull request Jan 13, 2020
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThadHouse @NancyLi1013 @dan-shaw