Skip to content

[restclient-cpp]: correct the way to remove debug/include#9487

Merged
vicroms merged 3 commits intomicrosoft:masterfrom
curoky:master
Jan 29, 2020
Merged

[restclient-cpp]: correct the way to remove debug/include#9487
vicroms merged 3 commits intomicrosoft:masterfrom
curoky:master

Conversation

@curoky
Copy link
Contributor

@curoky curoky commented Dec 28, 2019

Just need removing ${CURRENT_PACKAGES_DIR}/debug/include, not ${CURRENT_PACKAGES_DIR}/lib and ${CURRENT_PACKAGES_DIR}/bin.

@JackBoosY JackBoosY self-assigned this Dec 30, 2019
@JackBoosY JackBoosY self-requested a review December 30, 2019 03:09
@JackBoosY
Copy link
Contributor

The CI test reports:

2019-12-28T12:24:48.1340353Z -- Performing post-build validation
2019-12-28T12:24:48.1341935Z Import libs were not present in C:\vsts\_work\3\s\packages\restclient-cpp_x86-windows\debug\lib
2019-12-28T12:24:48.1343629Z If this is intended, add the following line in the portfile:
2019-12-28T12:24:48.1345668Z     SET(VCPKG_POLICY_DLLS_WITHOUT_LIBS enabled)
2019-12-28T12:24:48.1347511Z Import libs were not present in C:\vsts\_work\3\s\packages\restclient-cpp_x86-windows\lib
2019-12-28T12:24:48.1349063Z If this is intended, add the following line in the portfile:
2019-12-28T12:24:48.1351279Z     SET(VCPKG_POLICY_DLLS_WITHOUT_LIBS enabled)
2019-12-28T12:24:48.4992565Z The following DLLs have no exports:
2019-12-28T12:24:48.4994289Z 
2019-12-28T12:24:48.4997696Z     C:/vsts/_work/3/s/packages/restclient-cpp_x86-windows/debug/bin/restclient-cppd.dll
2019-12-28T12:24:48.4999850Z     C:/vsts/_work/3/s/packages/restclient-cpp_x86-windows/bin/restclient-cpp.dll
2019-12-28T12:24:48.5001783Z 
2019-12-28T12:24:48.5004075Z DLLs without any exports are likely a bug in the build script.
2019-12-28T12:24:48.9199924Z There should be no empty directories in C:\vsts\_work\3\s\packages\restclient-cpp_x86-windows
2019-12-28T12:24:48.9227415Z The following empty directories were found:
2019-12-28T12:24:48.9227698Z 
2019-12-28T12:24:48.9230345Z     C:/vsts/_work/3/s/packages/restclient-cpp_x86-windows/debug/lib
2019-12-28T12:24:48.9232676Z     C:/vsts/_work/3/s/packages/restclient-cpp_x86-windows/lib
2019-12-28T12:24:48.9234393Z 
2019-12-28T12:24:48.9236674Z If a directory should be populated but is not, this might indicate an error in the portfile.
2019-12-28T12:24:48.9238957Z If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them:
2019-12-28T12:24:48.9240698Z 
2019-12-28T12:24:48.9243840Z     file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/a/dir ${CURRENT_PACKAGES_DIR}/some/other/dir)
2019-12-28T12:24:48.9245849Z 
2019-12-28T12:24:48.9247821Z 
2019-12-28T12:24:48.9250064Z Found 4 error(s). Please correct the portfile:
2019-12-28T12:24:48.9253404Z     C:\vsts\_work\3\s\ports\restclient-cpp\portfile.cmake
2019-12-28T12:24:48.9255258Z -- Performing post-build validation done
2019-12-28T12:24:49.0651015Z Error: Building package restclient-cpp:x86-windows failed with: POST_BUILD_CHECKS_FAILED
2019-12-28T12:24:49.0652679Z Elapsed time for package restclient-cpp:x86-windows: 11.76 s

@JackBoosY
Copy link
Contributor

/azp run

1 similar comment
@JackBoosY
Copy link
Contributor

/azp run

@SeekingMeaning
Copy link
Contributor

Hmm, perhaps update the cmake linking patch like mrtazz/restclient-cpp#135 (The ppconsul regression should be fixed by #9752)

@JackBoosY
Copy link
Contributor

@curoky Yes, but we do have restclient-cpp:windows regreession. Please see test results.

@curoky
Copy link
Contributor Author

curoky commented Jan 19, 2020

Maybe i need to update the cmake-link patch.
I can't test it in window, i just have linux environment.

@JackBoosY
Copy link
Contributor

JackBoosY commented Jan 19, 2020

@curoky I've fixed it.

@msftclas
Copy link

msftclas commented Jan 19, 2020

CLA assistant check
All CLA requirements met.

@JackBoosY
Copy link
Contributor

Please sign CLA. Thanks.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 22, 2020
@vicroms
Copy link
Member

vicroms commented Jan 27, 2020

/azp run

@vicroms vicroms merged commit f272b0c into microsoft:master Jan 29, 2020
@vicroms
Copy link
Member

vicroms commented Jan 29, 2020

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants