[restclient-cpp]: correct the way to remove debug/include#9487
Merged
vicroms merged 3 commits intomicrosoft:masterfrom Jan 29, 2020
curoky:master
Merged
[restclient-cpp]: correct the way to remove debug/include#9487vicroms merged 3 commits intomicrosoft:masterfrom curoky:master
vicroms merged 3 commits intomicrosoft:masterfrom
curoky:master
Conversation
Contributor
|
The CI test reports: |
Contributor
|
/azp run |
1 similar comment
Contributor
|
/azp run |
Contributor
|
Hmm, perhaps update the cmake linking patch like mrtazz/restclient-cpp#135 (The ppconsul regression should be fixed by #9752) |
Contributor
|
@curoky Yes, but we do have restclient-cpp:windows regreession. Please see test results. |
Contributor
Author
|
Maybe i need to update the cmake-link patch. |
Contributor
|
@curoky I've fixed it. |
JackBoosY
approved these changes
Jan 19, 2020
Contributor
|
Please sign CLA. Thanks. |
Member
|
/azp run |
Member
|
Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just need removing
${CURRENT_PACKAGES_DIR}/debug/include, not${CURRENT_PACKAGES_DIR}/liband${CURRENT_PACKAGES_DIR}/bin.