[osg] fix non-windows builds#9441
Closed
Outurnate wants to merge 2 commits intomicrosoft:masterfrom
Outurnate:osg
Closed
[osg] fix non-windows builds#9441Outurnate wants to merge 2 commits intomicrosoft:masterfrom Outurnate:osg
Outurnate wants to merge 2 commits intomicrosoft:masterfrom
Outurnate:osg
Conversation
NancyLi1013
suggested changes
Dec 26, 2019
Contributor
|
Hi @Outurnate thanks for this PR. |
Contributor
Author
|
Fixes #9446 All requested changes made. Some automated checks had recommendations as well. There were also some windows-centric bits that I fixed |
Contributor
Contributor
Author
|
Sorry, no, it's #9449 |
Contributor
|
Since |
Contributor
|
/azp run |
Contributor
Author
|
I'll need to modify osg to build the tools again. osgearth depends on it |
Contributor
|
/azp run |
Contributor
|
Could you please resolve the conflicts? |
Contributor
|
@Outurnate |
Contributor
|
Thanks for the PR; we're closing this for now since there's been no response. If you'd like to continue working on it, please reopen and ping us! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling OSG_USE_UTF8_FILENAME on any platform other than windows causes the build to fail. This is because it substitutes fopen for _wfopen, which is only on windows.
Related: #9449.