[expat] Update the version to 2.2.9 (add support for uwp) by NancyLi1013 · Pull Request #9146 · microsoft/vcpkg

NancyLi1013 · 2019-11-29T09:36:45Z

Update to 2.2.9

Add support for uwp
Supportfind_package()by expat-config.cmake instead of Findexpat.cmake(Remove usage in ports/expat/usage)

Fix #3174, #11840

…NancyLi/3174-update-expat

NancyLi1013 · 2020-01-06T02:50:10Z

/azp run

NancyLi1013 · 2020-01-14T02:05:01Z

/azp run

NancyLi1013 · 2020-02-20T02:17:21Z

/azp run

NancyLi1013 · 2020-03-20T06:23:03Z

/azp run

NancyLi1013 · 2020-04-16T09:14:57Z

/azp run

azure-pipelines · 2020-04-16T09:15:03Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

…NancyLi/3174-update-expat

ray42 · 2020-05-27T15:58:49Z

@NancyLi1013 @JackBoosY what needs to be done to get this merged? Anything I could help with? I would love to get expat v2.2.9, thanks.

JackBoosY · 2020-05-27T16:20:30Z

/azp run

azure-pipelines · 2020-05-27T16:20:38Z

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY · 2020-05-28T02:14:38Z

@ray42 we are trying to solve the baseline error, then we will handle this PR.

ray42 · 2020-05-28T06:08:07Z

@JackBoosY Thank you.

@NancyLi1013 - let me know if there is anything I can help out with, thank you.

NancyLi1013 · 2020-06-01T07:43:49Z

/azp run

azure-pipelines · 2020-06-01T07:43:57Z

Azure Pipelines successfully started running 1 pipeline(s).

…NancyLi/3174-update-expat

NancyLi1013 · 2020-06-09T06:48:57Z

/azp run

azure-pipelines · 2020-06-09T06:49:05Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2020-07-30T08:12:43Z

The regression on x64-osx for itk is due to the following cause, which will be fixed in PR #11208.

Undefined symbols for architecture x86_64:
  "gdcm::Rescaler::SetMinMaxForPixelType(double, double)", referenced from:
      itk::GDCMImageIO::Write(void const*) in libITKIOGDCM-5.0.a(itkGDCMImageIO.cxx.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

strega-nil · 2020-07-30T16:19:42Z

@NancyLi1013 is this itk failure going to happen regardless, or should we wait for #11208 to be merged?

NancyLi1013 · 2020-07-31T01:55:38Z

The itk failure will happen regardless, which has existed for long time . It seems that this issue appeared in this PR #10767 (comment) for the first time and the failure code was removed from ci.baseline.txt in #11513. It appeared again in ##12067 (comment) and #12133.

It should not block this PR. But we can also wait for #11208 merged and then try to rerun this PR. There are also many changes in this PR. We may wait for all CI checks have passed.

…NancyLi/3174-update-expat # Conflicts: # ports/wxwidgets/portfile.cmake

strega-nil · 2020-08-05T17:37:28Z

/azp run

azure-pipelines · 2020-08-05T17:37:37Z

Azure Pipelines successfully started running 1 pipeline(s).

strega-nil · 2020-08-05T19:47:26Z

@NancyLi1013 what's going on with itk and cmake on windows, do you know?

…NancyLi/3174-update-expat # Conflicts: # ports/wxwidgets/CONTROL # ports/wxwidgets/portfile.cmake

NancyLi1013 · 2020-08-06T07:44:36Z

@strega-nil

For the regressions caused by itk, I'm in investigation now.
For cmake, I don't know why it will fail.

I resolved the conflicts for wxwidgets just now. Let's wait for the new results.

strega-nil · 2020-08-07T00:10:19Z

/azp run

azure-pipelines · 2020-08-07T00:10:28Z

Azure Pipelines successfully started running 1 pipeline(s).

…NancyLi/3174-update-expat

NancyLi1013 · 2020-08-07T09:55:17Z

The regressions for itk have been fixed now.
But for cmake, I have no idea.

[503/504] cmd.exe /C "cd /D D:\buildtrees\cmake\x64-windows-dbg && D:\buildtrees\cmake\x64-windows-dbg\bin\cmake.exe -P cmake_install.cmake"
FAILED: CMakeFiles/install.util 
cmd.exe /C "cd /D D:\buildtrees\cmake\x64-windows-dbg && D:\buildtrees\cmake\x64-windows-dbg\bin\cmake.exe -P cmake_install.cmake"
ninja: build stopped: subcommand failed.

@strega-nil

Could you please help take a look? I don't know what's wrong with cmake.

…NancyLi/3174-update-expat

NancyLi1013 · 2020-08-14T02:06:54Z

@strega-nil
Thanks for your help to fix cmake issue.

I noticed that you updated cmake to 3.18.1 and also disable -DCMAKE_USE_SYSTEM_EXPAT=OFF.

I tried to install cmake 3.17.2 via .\vcpkg.exe install cmake --overlay-ports=scripts/test_ports on my local on both master branch and expat branch, it failed with the same error, which is different from CI results.

The results from expat branch:

F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(39): error C2672: 'cm::static_reference_cast': no matching overloaded function found
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(39): error C2783: 'T &cm::static_reference_cast(O &)': could not deduce template argument for '__formal'
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Utilities\std\cmext/memory(19): note: see declaration of 'cm::static_reference_cast'
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(55): error C2672: 'cm::static_reference_cast': no matching overloaded function found
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(55): error C2783: 'T &cm::static_reference_cast(O &)': could not deduce template argument for '__formal'
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Utilities\std\cmext/memory(19): note: see declaration of 'cm::static_reference_cast'
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(57): error C2672: 'cm::static_reference_cast': no matching overloaded function found
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(57): error C2783: 'T &cm::static_reference_cast(O &)': could not deduce template argument for '__formal'
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Utilities\std\cmext/memory(19): note: see declaration of 'cm::static_reference_cast'
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(217): error C2672: 'cm::static_reference_cast': no matching overloaded function found
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(217): error C2783: 'T &cm::static_reference_cast(O &)': could not deduce template argument for '__formal'
F:\expet\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Utilities\std\cmext/memory(19): note: see declaration of 'cm::static_reference_cast'

The results from master branch:

F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(39): error C2672: 'cm::static_reference_cast': no matching overloaded function found
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(39): error C2783: 'T &cm::static_reference_cast(O &)': could not deduce template argument for '__formal'
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Utilities\std\cmext/memory(19): note: see declaration of 'cm::static_reference_cast'
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(55): error C2672: 'cm::static_reference_cast': no matching overloaded function found
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(55): error C2783: 'T &cm::static_reference_cast(O &)': could not deduce template argument for '__formal'
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Utilities\std\cmext/memory(19): note: see declaration of 'cm::static_reference_cast'
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(57): error C2672: 'cm::static_reference_cast': no matching overloaded function found
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(57): error C2783: 'T &cm::static_reference_cast(O &)': could not deduce template argument for '__formal'
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Utilities\std\cmext/memory(19): note: see declaration of 'cm::static_reference_cast'
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(217): error C2672: 'cm::static_reference_cast': no matching overloaded function found
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Source\cmGeneratorExpressionParser.cxx(217): error C2783: 'T &cm::static_reference_cast(O &)': could not deduce template argument for '__formal'
F:\new\vcpkg\buildtrees\cmake\src\7fc4616c28-392dff6306.clean\Utilities\std\cmext/memory(19): note: see declaration of 'cm::static_reference_cast'

So I'm not sure if the regressions on CI are related with the changes in this PR. I also have a doubt that why you update cmake to 3.18.1?

strega-nil · 2020-08-14T16:29:13Z

@NancyLi1013 yeah, that was a thing that was broken in that version of CMake with the latest version of VC++.

…NancyLi/3174-update-expat # Conflicts: # ports/wxwidgets/CONTROL

…ncyLi1013/vcpkg into dev/NancyLi/3174-update-expat

NancyLi1013 · 2020-08-18T01:08:24Z

@strega-nil thanks for your help.

ray42 · 2020-08-18T04:29:12Z

Thanks to everyone, especially @NancyLi1013 , for the awesome work :)

…9146) * [expat] Update the version to 2.2.9(support uwp) * [readosm] Fix expat.lib cannot be found * Remove expat:arm-uwp and expat:x64-uwp from fail list in ci.baseline.txt * [apr-util,io2d,skia] Fix expat cannot be found and also update expat * [many ports] Add supports and fix the regressions * Fix new regressions * Fix typo * [io2d] Update expat patch * [io2d,libkml,skia] Fix expat cannot find and also fix typo * [expat] Remove usage * [libkml,vtk] Update expat patch and fix static build * [wxwidgets] Fix static build caused by expat cannot found * Update as review suggestion * Add Port-Version * Remove evpp:x64-osx=fail from ci.baseline.txt * [wxwidgest] Remove unnecessary spaces * [itk] Fix expat cannot be found * fix cmake test port * [wxwidgets] Update Port-Version Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com>

[expat] Update the version to 2.2.9(support uwp)

a8f32c5

NancyLi1013 added the internal label Nov 29, 2019

NancyLi1013 requested a review from JackBoosY November 29, 2019 09:36

grdowns self-assigned this Dec 2, 2019

[readosm] Fix expat.lib cannot be found

4be1814

NancyLi1013 marked this pull request as ready for review December 11, 2019 06:02

NancyLi1013 assigned JackBoosY Dec 27, 2019

NancyLi1013 added 2 commits December 26, 2019 23:20

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

5d5893e

…NancyLi/3174-update-expat

Remove expat:arm-uwp and expat:x64-uwp from fail list in ci.baseline.txt

18737a7

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

afbe324

…NancyLi/3174-update-expat

ray42 unassigned grdowns May 27, 2020

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

ed54804

…NancyLi/3174-update-expat

NancyLi1013 mentioned this pull request Jun 9, 2020

expat:x64-uwp #11840

Closed

[apr-util,io2d,skia] Fix expat cannot be found and also update expat

de21165

JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 11, 2020

NancyLi1013 added depends:different-pr This PR or Issue depends on a PR which has been filed and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jul 30, 2020

NancyLi1013 added 2 commits August 2, 2020 19:02

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

c5833c8

…NancyLi/3174-update-expat # Conflicts: # ports/wxwidgets/portfile.cmake

[wxwidgest] Remove unnecessary spaces

90749f8

NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 3, 2020

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

ea98684

…NancyLi/3174-update-expat # Conflicts: # ports/wxwidgets/CONTROL # ports/wxwidgets/portfile.cmake

NancyLi1013 added 2 commits August 7, 2020 02:13

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

8d1c723

…NancyLi/3174-update-expat

[itk] Fix expat cannot be found

f6fdd81

NancyLi1013 and others added 2 commits August 12, 2020 01:09

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

dccc91e

…NancyLi/3174-update-expat

fix cmake test port

82e0a92

NancyLi1013 added 3 commits August 16, 2020 20:07

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

7636224

…NancyLi/3174-update-expat # Conflicts: # ports/wxwidgets/CONTROL

[wxwidgets] Update Port-Version

c6ebfe9

Merge branch 'dev/NancyLi/3174-update-expat' of https://github.com/Na…

fcde474

…ncyLi1013/vcpkg into dev/NancyLi/3174-update-expat

strega-nil merged commit d6285bc into microsoft:master Aug 17, 2020

Conversation

NancyLi1013 commented Nov 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Jan 6, 2020

Uh oh!

NancyLi1013 commented Jan 14, 2020

Uh oh!

NancyLi1013 commented Feb 20, 2020

Uh oh!

NancyLi1013 commented Mar 20, 2020

Uh oh!

NancyLi1013 commented Apr 16, 2020

Uh oh!

azure-pipelines bot commented Apr 16, 2020

Uh oh!

ray42 commented May 27, 2020

Uh oh!

JackBoosY commented May 27, 2020

Uh oh!

azure-pipelines bot commented May 27, 2020

Uh oh!

JackBoosY commented May 28, 2020

Uh oh!

ray42 commented May 28, 2020

Uh oh!

NancyLi1013 commented Jun 1, 2020

Uh oh!

azure-pipelines bot commented Jun 1, 2020

Uh oh!

NancyLi1013 commented Jun 9, 2020

Uh oh!

azure-pipelines bot commented Jun 9, 2020

Uh oh!

NancyLi1013 commented Jul 30, 2020

Uh oh!

strega-nil commented Jul 30, 2020

Uh oh!

NancyLi1013 commented Jul 31, 2020

Uh oh!

strega-nil commented Aug 5, 2020

Uh oh!

azure-pipelines bot commented Aug 5, 2020

Uh oh!

strega-nil commented Aug 5, 2020

Uh oh!

NancyLi1013 commented Aug 6, 2020

Uh oh!

strega-nil commented Aug 7, 2020

Uh oh!

azure-pipelines bot commented Aug 7, 2020

Uh oh!

NancyLi1013 commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Aug 14, 2020

Uh oh!

strega-nil commented Aug 14, 2020

Uh oh!

NancyLi1013 commented Aug 18, 2020

Uh oh!

ray42 commented Aug 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NancyLi1013 commented Nov 29, 2019 •

edited

Loading

NancyLi1013 commented Aug 7, 2020 •

edited

Loading