[libmpeg2] Add new port by janisozaur · Pull Request #8871 · microsoft/vcpkg

janisozaur · 2019-11-03T21:21:57Z

Libmpeg2 seems to be a somewhat old project, last release was done in
2008, but it is still in use by some projects e.g. ResidualVM

I have verified the mpeg2dec built for x86-64 with MSVC produces similar
results as the one pre-packaged on my Arch.

ports/libmpeg2/CMakeLists.txt

NancyLi1013 · 2019-11-19T02:42:36Z

/azp run

ports/libmpeg2/CONTROL

ports/libmpeg2/portfile.cmake

NancyLi1013 · 2019-11-25T07:16:37Z

Feature tested pass with the following triplets:

x86-windows (pass)
x64-windows-static (pass)
arm64-windows (pass)
arm-uwp (not supported)
x64-uwp (not supported)

This port currently only supports windows platform except for arm64-uwp, x86-uwp, x64-uwp triplets.

janisozaur · 2019-11-25T07:24:08Z

Updated with all the requests

janisozaur · 2019-12-04T19:45:40Z

Ping

vicroms · 2019-12-04T21:14:20Z

/azp run

janisozaur · 2019-12-09T08:47:29Z

Ping

dan-shaw · 2019-12-10T04:23:16Z

@janisozaur Currently the MacOS pipeline is down, so we will have to wait on this.

janisozaur · 2019-12-10T17:25:10Z

Is it required even if the package explicitly doesn't support that os? https://github.com/microsoft/vcpkg/blob/8e0d3e78284c6c8847ceea3dd1ad6f23c44997e9/ports/libmpeg2/portfile.cmake#L1

NancyLi1013 · 2019-12-18T01:42:11Z

Hi @janisozaur thanks for this PR.
Since this port doesn't support osx, linux, uwp.
Could you please update ci.baseline.txt with the followings?

libmpeg2:x64-uwp=fail
libmpeg2:arm-uwp=fail
libmpeg2:x64-linux=fail
libmpeg2:x64-osx=fail

janisozaur · 2019-12-18T09:49:46Z

Done

dan-shaw · 2020-01-09T00:40:25Z

/azp run

ras0219-msft · 2020-02-04T23:37:46Z

/azp run

ports/libmpeg2/0001-Add-naive-MSVC-support-to-sources.patch

ports/libmpeg2/CMakeLists.txt

ports/libmpeg2/CONTROL

janisozaur · 2020-04-07T11:39:07Z

##[error] REGRESSION: qt5-tools:x64-linux

Unrelated regression again.

NancyLi1013 · 2020-04-08T02:41:01Z

Thanks for your attention.
We will fix the regression as soon as possible.

janisozaur · 2020-04-15T14:26:26Z

All checks passing now

NancyLi1013 · 2020-04-16T02:24:56Z

Thanks for your reminder.
LGTM now.

janisozaur · 2020-04-30T19:48:01Z

Finally all green.

strega-nil

That's the only thing I see that needs changing; this is really cool, thanks!

ports/libmpeg2/0002-Mark-functions-as-exported.patch

janisozaur · 2020-05-04T19:55:15Z

Ping. It seems there is misconfiguration in the Azure Pipelines, this job has been running for close to half an hour now, in particular the x64_linux one, while this port only supports Windows and I'm sure it would take much less than this to compile vcpkg+libmpeg2 if it were supported. Previous force push also stalled for about two days.

Libmpeg2 seems to be a somewhat old project, last release was done in 2008, but it is still in use by some projects e.g. ResidualVM I have verified the mpeg2dec built for x86-64 with MSVC produces similar results as the one pre-packaged on my Arch.

strega-nil · 2020-05-05T21:00:28Z

@janisozaur this looks good; I'll merge as soon as we get LLVM working again.

JackBoosY · 2020-05-06T03:07:04Z

/azp run

azure-pipelines · 2020-05-06T03:07:12Z

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY · 2020-05-06T06:45:40Z

/azp run

azure-pipelines · 2020-05-06T06:45:48Z

Azure Pipelines successfully started running 1 pipeline(s).

strega-nil · 2020-05-06T17:46:17Z

/azp run

azure-pipelines · 2020-05-06T17:46:25Z

Azure Pipelines successfully started running 1 pipeline(s).

strega-nil · 2020-05-06T20:53:36Z

Alright, awesome! Thanks @janisozaur, this is great 😄

janisozaur · 2020-05-06T21:07:24Z

Finally! Thanks, now on to updating that scummvm build…

PhoebeHui requested a review from NancyLi1013 November 12, 2019 07:15

janisozaur commented Nov 13, 2019

View reviewed changes

ports/libmpeg2/CMakeLists.txt Outdated Show resolved Hide resolved

grdowns assigned vicroms Nov 18, 2019

grdowns changed the title ~~[libmpeg2] Add libmpeg2 port~~ [libmpeg2] Add new port Nov 19, 2019

janisozaur force-pushed the libmpeg2 branch from 83d1a54 to 9144da6 Compare November 21, 2019 14:31

NancyLi1013 suggested changes Nov 25, 2019

View reviewed changes

ports/libmpeg2/CONTROL Outdated Show resolved Hide resolved

ports/libmpeg2/portfile.cmake Outdated Show resolved Hide resolved

ports/libmpeg2/portfile.cmake Outdated Show resolved Hide resolved

ports/libmpeg2/portfile.cmake Outdated Show resolved Hide resolved

janisozaur force-pushed the libmpeg2 branch from 9144da6 to 172ba7c Compare November 25, 2019 07:23

NancyLi1013 approved these changes Nov 25, 2019

View reviewed changes

janisozaur force-pushed the libmpeg2 branch from 172ba7c to 8e0d3e7 Compare December 9, 2019 08:47

NancyLi1013 self-assigned this Dec 17, 2019

janisozaur force-pushed the libmpeg2 branch from 8e0d3e7 to 7c49bdb Compare December 18, 2019 09:49

NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Dec 20, 2019

janisozaur force-pushed the libmpeg2 branch from d15238a to 251c584 Compare January 9, 2020 11:24

janisozaur force-pushed the libmpeg2 branch from 251c584 to 68a4fc4 Compare January 27, 2020 14:58

ras0219-msft reviewed Feb 6, 2020

View reviewed changes

ports/libmpeg2/0001-Add-naive-MSVC-support-to-sources.patch Outdated Show resolved Hide resolved

ras0219-msft requested changes Feb 6, 2020

View reviewed changes

ports/libmpeg2/CMakeLists.txt Outdated Show resolved Hide resolved

ports/libmpeg2/CONTROL Outdated Show resolved Hide resolved

janisozaur force-pushed the libmpeg2 branch from 949c828 to 20d314b Compare April 15, 2020 14:15

ras0219-msft approved these changes Apr 27, 2020

View reviewed changes

JackBoosY mentioned this pull request Apr 28, 2020

[armadillo] Add dependent port superlu on osx #11063

Merged

janisozaur force-pushed the libmpeg2 branch 2 times, most recently from b90cb8f to f3a8772 Compare April 30, 2020 19:29

strega-nil suggested changes May 1, 2020

View reviewed changes

ports/libmpeg2/0002-Mark-functions-as-exported.patch Outdated Show resolved Hide resolved

janisozaur force-pushed the libmpeg2 branch 2 times, most recently from 2b26cdf to 7bc37e6 Compare May 4, 2020 19:30

janisozaur added 3 commits May 5, 2020 18:56

[libmpeg2] Add new port

fb30ff9

Libmpeg2 seems to be a somewhat old project, last release was done in 2008, but it is still in use by some projects e.g. ResidualVM I have verified the mpeg2dec built for x86-64 with MSVC produces similar results as the one pre-packaged on my Arch.

[libmpeg2] Add ci.baseline.txt exemptions

ecf3ec5

[libmpeg2] Apply review comments

e3acda3

janisozaur force-pushed the libmpeg2 branch from 7bc37e6 to e3acda3 Compare May 5, 2020 16:56

JackBoosY mentioned this pull request May 6, 2020

[vcpkg] Add tombstone deletion scripts. #11189

Merged

strega-nil merged commit 305785b into microsoft:master May 6, 2020

janisozaur deleted the libmpeg2 branch May 6, 2020 21:06

Conversation

janisozaur commented Nov 3, 2019

Uh oh!

Uh oh!

NancyLi1013 commented Nov 19, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Nov 25, 2019

Uh oh!

janisozaur commented Nov 25, 2019

Uh oh!

janisozaur commented Dec 4, 2019

Uh oh!

vicroms commented Dec 4, 2019

Uh oh!

janisozaur commented Dec 9, 2019

Uh oh!

dan-shaw commented Dec 10, 2019

Uh oh!

janisozaur commented Dec 10, 2019

Uh oh!

NancyLi1013 commented Dec 18, 2019

Uh oh!

janisozaur commented Dec 18, 2019

Uh oh!

dan-shaw commented Jan 9, 2020

Uh oh!

ras0219-msft commented Feb 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janisozaur commented Apr 7, 2020

Uh oh!

NancyLi1013 commented Apr 8, 2020

Uh oh!

janisozaur commented Apr 15, 2020

Uh oh!

NancyLi1013 commented Apr 16, 2020

Uh oh!

janisozaur commented Apr 30, 2020

Uh oh!

strega-nil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

janisozaur commented May 4, 2020

Uh oh!

strega-nil commented May 5, 2020

Uh oh!

JackBoosY commented May 6, 2020

Uh oh!

azure-pipelines bot commented May 6, 2020

Uh oh!

JackBoosY commented May 6, 2020

Uh oh!

azure-pipelines bot commented May 6, 2020

Uh oh!

strega-nil commented May 6, 2020

Uh oh!

azure-pipelines bot commented May 6, 2020

Uh oh!

strega-nil commented May 6, 2020

Uh oh!

janisozaur commented May 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants