[opencv4] Upgrade to version 4.1.2#8557
Conversation
|
Also, since we are updating, I suggest you another update related to tesseract and a proper management of dependencies also for contrib modules. It is really necessary in order to not let them build depending on previous packets installed on user machine |
|
Finally, for consistency and compatibility, I’d push for a simultaneous update of opencv3 to 3.4.8 |
|
vcpkg_fixup_cmake_targets fix files *.lib path in OpenCVModules-debug.cmake, the files *d.dll path are wrong. Some ports depend on opencv4 will build failed due to can't find *d.dll. I Modify the files *d.dll path in portfile by file(write OpenCVModules-debug.cmake). |
There is no such problem in current PR (see your own issue for more details). Also please do not delete the Sorry for interfering, but I spent so much time in the OpenCV port that I expect it is preserved in the best state possible, and not updated in a hurry without care (@vicroms might remember...) |
| file(READ ${CURRENT_PACKAGES_DIR}/share/opencv/OpenCVModules-debug.cmake DLL_PATH) | ||
| string(REPLACE /x86/vc | ||
| /debug/x86/vc DLL_PATH "${DLL_PATH}") | ||
| file(WRITE ${CURRENT_PACKAGES_DIR}/share/opencv/OpenCVModules-debug.cmake "${DLL_PATH}") |
There was a problem hiding this comment.
Perhaps, CMake option -DOpenCV_ARCH=debug/${VCPKG_TARGET_ARCHITECTURE} should handle that.
But it requires to specify OpenCV_RUNTIME too (vc14/vc15/etc)
(alternative is OPENCV_INSTALL_BINARIES_PREFIX=debug/${VCPKG_TARGET_ARCHITECTURE}/vc14)
There was a problem hiding this comment.
note that Dlls in vcpkg must go into the bin folder, not any of those here............
There was a problem hiding this comment.
Try to pass OPENCV_INSTALL_BINARIES_PREFIX= (empty)
or something like (depends on vcpkg layout policies):
OPENCV_BIN_INSTALL_PATH=binOPENCV_INCLUDE_INSTALL_PATH=includeOPENCV_LIB_INSTALL_PATH=libOPENCV_CONFIG_INSTALL_PATH=cmake
|
Soooo... maybe skip to 4.2 ? |
|
Or OpenCV 4.3 ? |
|
I will try my best to prepare a PR in the next few days for a proper OpenCV update to v4.3 |
|
@cenit Thanks, your work on the OpenCV ports was amazing and has helped us a lot in the past! |
|
Closing PR due to no progress being made. See #11130 |
9 participants
Related issue: #8549