Add option VCPKG_QMAKE_USE_NMAKE in vcpkg_build_qmake and install_qt

[JackBoosY]

Since the jam problem of jom cannot be solved temporarily, add the PREFER_NMAKE option.

Related: #4692 #7061.

[JackBoosY]

@voskrese @Neumann-A @TheScarfix @heydojo
Could you check this?
Thanks.

[Neumann-A]

The problem with that change is I cannot set the variable from the triplet but have to go into the ports to change the call of vcpkg_build_qmake to include PREFER_NMAKE. It would be nice if there was a variable like VCPKG_PREFER_NMAKE which could be set from a triplet. (the same is true for PREFER_NINJA)
Also setting the ENV{CL} to include /MP is missing. So i will not test out this PR since it will take ages to compile without the MP flag ;)

[JackBoosY]

@Neumann-A

The problem with that change is I cannot set the variable from the triplet but have to go into the ports to change the call of vcpkg_build_qmake to include PREFER_NMAKE. It would be nice if there was a variable like VCPKG_PREFER_NMAKE which could be set from a triplet. (the same is true for PREFER_NINJA)

This feature may require follow-up support.

Also setting the ENV{CL} to include /MP is missing. So i will not test out this PR since it will take ages to compile without the MP flag ;)

Added.

[ras0219-msft]

Since the only reason to use this PREFER_NMAKE is in the case that JOM deadlocks (and we only have @Neumann-A's report of that currently), I think the best option would be to just assume it as a global setting instead of a function argument. This should be as easy as removing it from the function argument list and replacing _bc_PREFER_NMAKE with the global setting name (e.g. VCPKG_QMAKE_USE_NMAKE)

[JackBoosY]

/azp run

[Neumann-A]

VCPKG_QMAKE_USE_NMAKE seems to work as intended. Build parts of Qt as part of another paraview branch updated with Qt 5.14 a few times and did not observe any problem with it.

[JackBoosY]

/azp run

[BillyONeal]

Starting package 3/7: qt5-imageformats:x86-windows
Building package qt5-imageformats[core]:x86-windows...
-- Using cached D:/vcpkg/downloads/qtimageformats-everywhere-src-5.12.8.tar.xz
-- Extracting source D:/vcpkg/downloads/qtimageformats-everywhere-src-5.12.8.tar.xz
-- Using source at D:/vcpkg/buildtrees/qt5-imageformats/src/5.12.8-3efb8f5273
-- Configuring x86-windows-rel
-- Configuring x86-windows-rel done
-- Configuring x86-windows-dbg
-- Configuring x86-windows-dbg done
-- Package build-x86-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
    Command failed: "C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.26.28801/bin/Hostx64/x86/nmake.exe" -j 65
    Working Directory: D:/vcpkg/buildtrees/qt5-imageformats/x86-windows-dbg
    Error code: 2
    See logs for more information:
      D:\vcpkg\buildtrees\qt5-imageformats\package-build-x86-windows-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_qmake.cmake:40 (vcpkg_execute_required_process)
  scripts/cmake/vcpkg_build_qmake.cmake:75 (run_jom)
  installed/x86-windows/share/qt5/qt_build_submodule.cmake:12 (vcpkg_build_qmake)
  installed/x86-windows/share/qt5/qt_submodule_installation.cmake:8 (qt_build_submodule)
  ports/qt5-imageformats/portfile.cmake:54 (qt_submodule_installation)
  scripts/ports.cmake:76 (include)


Error: Building package qt5-imageformats:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: qt5-imageformats:x86-windows
  Vcpkg version: 2020.02.04-nohash

Additionally, attach any relevant sections from the log files above.

Looks like qt might not be ready for this :(

[JackBoosY]

@BillyONeal Because using nmake to build will use more time.

[Neumann-A]

Looks like qt might not be ready for this :(

Qt is designed to be used with nmake.... just saying (it even tells you to use nmake at the end of one of the qt5-base config logs)

 Any reason we wouldn't want this setting to be the default if it fixes a known hang?

As has been said above it is a bit slower.

[Neumann-A]

@BillyONeal: Please check logs next time:

NMAKE : fatal error U1065: invalid option 'j'
Stop.

So move the -j option into INVOKE e.g.
set(INVOKE "${JOM}" -j ${VCPKG_CONCURRENCY})
and
set(INVOKE "${MAKE}" -j ${VCPKG_CONCURRENCY})

[BillyONeal]

Any reason we wouldn't want this setting to be the default if it fixes a known hang?

As has been said above it is a bit slower.

I see the hang almost every time so it might not end up slower for some :)

[Neumann-A]

due to the additional comment in #4692 (comment) should this PR be made mergeable again?

[ras0219]

To add some data: on my local 3970X, qt5-base with JOM takes 8.06 minutes but with NMake takes 19.62 minutes

[strega-nil]

@JackBoosY could you remerge with master?

[JackBoosY]

@strega-nil Ready.

[strega-nil]

Thanks @JackBoosY !