Skip to content

[uchardet] Add new port#8477

Merged
strega-nil merged 10 commits intomicrosoft:masterfrom
myd7349:uchardet-init
Apr 28, 2020
Merged

[uchardet] Add new port#8477
strega-nil merged 10 commits intomicrosoft:masterfrom
myd7349:uchardet-init

Conversation

@myd7349
Copy link
Contributor

@myd7349 myd7349 commented Oct 7, 2019

Related issue: #8088 .

@vicroms
Copy link
Member

vicroms commented Oct 9, 2019

UWP failures

CMake Error at CMakeLists.txt:42 (string):
  string no output variable specified

@myd7349
Copy link
Contributor Author

myd7349 commented Oct 10, 2019

UWP failures

CMake Error at CMakeLists.txt:42 (string):
  string no output variable specified

Hi! @vicroms Thanks for your kindly help!

@myd7349 myd7349 marked this pull request as ready for review October 10, 2019 10:38
@JackBoosY
Copy link
Contributor

/azp run

@LilyWangL
Copy link
Contributor

/azp run

@JackBoosY
Copy link
Contributor

Seems build failure on uwp, can you check that?

Thanks.

@MVoz MVoz mentioned this pull request Mar 21, 2020
@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 28, 2020
@strega-nil
Copy link
Contributor

Alright, looks good! Thanks again @myd7349 :)

@strega-nil strega-nil merged commit be2f81f into microsoft:master Apr 28, 2020
@myd7349 myd7349 deleted the uchardet-init branch April 29, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants