Skip to content

[libodraw] Add new port#8155

Closed
AlexAltea wants to merge 1 commit intomicrosoft:masterfrom
AlexAltea:libodraw
Closed

[libodraw] Add new port#8155
AlexAltea wants to merge 1 commit intomicrosoft:masterfrom
AlexAltea:libodraw

Conversation

@AlexAltea
Copy link
Contributor

This port is very similar to the libqcow port proposed in #6852, which makes sense since both libraries are part of the same libyal collection (all written by the same author).

@cbezault
Copy link
Contributor

What platforms are supported by this library?

@cbezault cbezault requested review from vicroms and removed request for vicroms September 12, 2019 16:21
@AlexAltea
Copy link
Contributor Author

AlexAltea commented Sep 12, 2019

As per libodraw's "Building" page [1], Windows, Linux and macOS should be supported. Though I haven't tested this port in neither Linux nor macOS (I've only tested x86-windows and x64-windows).

The build jobs in all platforms seem to have failed, is it a strict requirement to make it work in all platforms (including UWP)?

[1] https://github.com/libyal/libodraw/wiki/Building

@cbezault
Copy link
Contributor

It's necessary to get the port to work on all supported triplets on at least one platform. So at least x64-osx, x64-linux, or all supported windows triplets (so if UWP is not supported by the library it is not necessary to get it to build for UWP).

@AlexAltea
Copy link
Contributor Author

AlexAltea commented Sep 30, 2019

@vicroms Thanks for the help. I've fixed that issue.

@cbezault Linux builds are fine now. Windows builds work, except for UWP ones, since one of the dependencies (zlib), cannot be build under x86-uwp or x64-uwp.

EDIT: The Linux build tests seem to have failed, despite me building it successfully. Is there any way of accessing /ci/myagent/_work/1/s/buildtrees/libodraw/install-x64-linux-dbg-out.log?

@vicroms
Copy link
Member

vicroms commented Oct 8, 2019

@AlexAltea

You should be able to download the failure logs for each platform by clicking the Summary tab and then downloading the port build failure logs zip file.

failurelogs

Signed-off-by: Alexandro Sanchez Bach <alexandro@phi.nz>
@AlexAltea
Copy link
Contributor Author

@vicroms Thank you! I just needed to add OpenSSL as a dependency. Now both Linux and Windows work (except UWP, for the reasons stated in #8155 (comment)).

@ras0219-msft
Copy link
Contributor

/azp run

@LilyWangL
Copy link
Contributor

/azp run

@@ -0,0 +1,37 @@
include(vcpkg_common_functions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include(vcpkg_common_functions) is deprecated. Please remove it.

@LilyWangL
Copy link
Contributor

Pinging @AlexAltea for response. Is work still being done for this PR?

@LilyWangL
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

@LilyWangL LilyWangL closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants