[WIP] [flatbuffers] Add support for iOS#7380
Closed
Helco wants to merge 3 commits intomicrosoft:masterfrom
Closed
Conversation
The toolchain is automatically picked up when CMAKE_SYSTEM_NAME equals iOS. The toolchain sets the architectures for which to build packages, as well as the processor type (because certain packages like libpng depend on their value). Automatic detection of triplets for iOS / tvOS / watchOS is added when using the vcpkg.cmake toolchain while building your own application. It uses the values of CMAKE_SYSTEM_NAME and CMAKE_OSX_ARCHITECTURES to detect the triplet. Fix (in a hacky way) find_package to find vcpkg installed packages. Reset the CMAKE_FIND_ROOT_PATH value, until upstream CMake removes its hardcoding of CMAKE_FIND_ROOT_PATH to Apple's SDK sysroot. Fixes: microsoft#6003
Contributor
|
@Helco, Is work still being done for this PR? |
Contributor
Author
|
Sadly not by me as I have no longer access to the necessary Apple devices anymore |
Contributor
|
Closing this PR, please reopen if still being worked on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for flatbuffers on iOS using the alcroito's work of PR #6275.
Neither the compiler nor the flathash executable should be compiled, same as with UWP.
This should be regarded as WIP, as I didn't got around testing it on hardware (hopefully in the next few days).
As to the location of the PR, I am also okay with this being merged into alcroito/ios_support first.