[osg] Fix link error caused by static tiff library#6674
Closed
Haojia521 wants to merge 8 commits intomicrosoft:masterfrom
Closed
[osg] Fix link error caused by static tiff library#6674Haojia521 wants to merge 8 commits intomicrosoft:masterfrom
Haojia521 wants to merge 8 commits intomicrosoft:masterfrom
Conversation
update codes from origin repo
update from original repo
update from original repo
[UFOR] 190520
[UFOP] 190522
[UFOR] 190527
This was referenced May 29, 2019
Contributor
|
It might be better to use Alternatively, we could include the dependencies inside the |
Contributor
Author
|
hi, @ras0219-msft . It's really a better way to use |
Contributor
|
Thanks for the PR! It looks like this is actually fixed by #6000, which adds the extra dependency libs to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osg fails to build because tiff is static library. #5889
The unresolved external symbols mainly form two libraries, jpeg and liblzma, so i add them to the target libs of osg plugin osgdb_tiff. And it seems to work.