Skip to content

[libgeotiff]Re-fix install files path.#6595

Closed
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/6591
Closed

[libgeotiff]Re-fix install files path.#6595
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/6591

Conversation

@JackBoosY
Copy link
Contributor

  • Use a patch instead of code to fix the installation file path.
  • Fix missing depends-debug.cmake issue.

Related: #6591.

@Neumann-A
Copy link
Contributor

Neumann-A commented May 24, 2019

hmm parallel PR #6596. Can we merge the best of both somehow?

looks like you can just add the geotiff-config.patch from #6596 and close #6596

@vicroms vicroms self-assigned this May 24, 2019
SET(DEFAULT_BIN_SUBDIR bin)
SET(DEFAULT_LIB_SUBDIR lib)
SET(DEFAULT_DATA_SUBDIR share)
+ SET(DEFAULT_TOOLS_SUBDIR tools)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to make the path tools/libgeotiff or tools/geotiff.
That way we don't have to add special handling in the portfile.

@JackBoosY
Copy link
Contributor Author

Since #6596 has been merged. Close this PR.

@JackBoosY JackBoosY closed this May 27, 2019
@JackBoosY JackBoosY deleted the dev/jack/6591 branch May 27, 2019 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants