[libmariadb]Disable test build.#6574
Merged
Rastaban merged 1 commit intomicrosoft:masterfrom May 24, 2019
JackBoosY:dev/jack/6562
Merged
[libmariadb]Disable test build.#6574Rastaban merged 1 commit intomicrosoft:masterfrom JackBoosY:dev/jack/6562
Rastaban merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/6562
Conversation
Contributor
|
Just wondering, how come this error wasn't detected before the update was merged? |
Contributor
Author
|
@OlafvdSpek , v3.0.5 still have problem. See #3962. |
Contributor
|
I see, but how that's related to the question? |
Contributor
Author
|
@OlafvdSpek I do not know. Maybe some macros or definitions have changed. |
Contributor
|
I kinda meant: is there no testing / continuous integration? |
Contributor
Author
|
@OlafvdSpek The test project in the source code is usually used by the author test. Once the port is released, the port is tested, so we don't need to use the test project. |
Contributor
|
But obviously this port didn't build, did it? |
Contributor
Author
|
It just can't build tests that we don't need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test project build relies on cctap.lib and the library is not found(LNK1104).
Although we can fix it, we don't need it. So I disabled the test project.
Related: #6562.