Skip to content

[freetds] Add new port#6566

Merged
Rastaban merged 1 commit intomicrosoft:masterfrom
maharmstone:master
May 24, 2019
Merged

[freetds] Add new port#6566
Rastaban merged 1 commit intomicrosoft:masterfrom
maharmstone:master

Conversation

@maharmstone
Copy link
Copy Markdown
Contributor

Adds port for FreeTDS (https://www.freetds.org/), the free implementation of the Tabular Data Stream protocol that Microsoft SQL Server uses to communicate.

@msftclas
Copy link
Copy Markdown

msftclas commented May 22, 2019

CLA assistant check
All CLA requirements met.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented May 23, 2019

Hi @maharmstone, thanks for the new port. Here are the test results from the current CI system:

x64-windows test notes
freetds Pass New Port
x64-windows-static test notes
freetds Pass New Port
x64-osx test notes
freetds Fail New Port
arm64-windows test notes
freetds Fail New Port
x86-windows test notes
freetds Pass New Port
x64-linux test notes
freetds Fail New Port
x64-uwp test notes
freetds Fail New Port
arm-uwp test notes
freetds Fail New Port

failureLogs.zip

@Rastaban
Copy link
Copy Markdown
Contributor

@maharmstone this port is looking good to me so far and is passing the windows and windows-static builds. Are you interested in investigating the failures on other triplets? If you don't have time then I will merge this as is and the other triplets can be addressed in a separate PR.

@maharmstone
Copy link
Copy Markdown
Contributor Author

Thanks - if you can merge it as it is for now, that'd be great.

I can't do anything about OS X or ARM, but the Linux version compiles alright on my Gentoo box, so it must be something minor - I'll send through a separate PR once I sort it.

@microsoft microsoft deleted a comment from crazy2013 May 23, 2019
@Rastaban
Copy link
Copy Markdown
Contributor

If the Linux build failure comes down to a missing dependency that needs to be added to the build machine let me know via an issue.

@Rastaban Rastaban merged commit d0f97f7 into microsoft:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants