[WIP][#5543 toolchain only] Fix library linkage (internal&external)#6555
Closed
Neumann-A wants to merge 10 commits intomicrosoft:masterfrom
Closed
[WIP][#5543 toolchain only] Fix library linkage (internal&external)#6555Neumann-A wants to merge 10 commits intomicrosoft:masterfrom
Neumann-A wants to merge 10 commits intomicrosoft:masterfrom
Conversation
This was referenced May 23, 2019
…multi config generators split function code from toolchain into seperate files split also some other code from the toolchain file into seperate files added override for find_library added override for set_target_properties (because some imported targets dont like generator expressions in IMPORT_LOCATION) added recursion guards since the overwrite of cmake internal functions is not really a supported feature added vcpkg_<cmakefunction> to counter the above and added extra options to disable the override of the cmake functions extend logic in find_package override(properly not required anymore and find_library handles all the cases!)
Neumann-A
force-pushed
the
fix_vcpkg_linkage_clean
branch
from
e2e9202 to
cae11b1
Compare
Contributor
Author
|
Can somebody run a full CI build with this PR? I am currently searching regressions and I do not know where to look anymore because so many fixes have been merged ;) |
…ogics must be overwritten
…_clean # Conflicts: # scripts/buildsystems/vcpkg.cmake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #5543 but only the toolchain changes without all the other port changes. The port changes are probably no longer required because I added the possibilities for find_library to add common debug suffixes to the searched library name (which also helps with future CMakes find_package Module updates).
fixing library linkage for internal and external uses for single and multi config generators