Skip to content

[unicorn-lib]Fix build error.#6534

Merged
Rastaban merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/6479
May 24, 2019
Merged

[unicorn-lib]Fix build error.#6534
Rastaban merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/6479

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented May 20, 2019

Fix link error:
  - Unable to link to the pcre2 library.
  - Unable to link to the zlib library.

  • Change library linkage to static.

Related: #6479.

@cenit
Copy link
Copy Markdown
Contributor

cenit commented May 20, 2019

If there are no lib files it means (almost always) that the dlls are empty.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

@cenit no, it generates the dll without generating lib. In static mode, it generates lib.

@cenit
Copy link
Copy Markdown
Contributor

cenit commented May 21, 2019

Exactly. Whats’s the size of the dlls? If it is few KB, they are probably empty and the project does not export any function or symbol. In that case, with empty dlls, MSVC does not produce a related lib file for the dll. Maybe the project works only with static linking. It’s easy, just try it in a downstream test project

@JackBoosY
Copy link
Copy Markdown
Contributor Author

Release dll is 584KB and debug dll is 2.23MB.

@Neumann-A
Copy link
Copy Markdown
Contributor

a quick search for declspec, extern, export shows that only extern is used. As such this is probably only a static library (on windows) or requires CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS.

@JackBoosY JackBoosY marked this pull request as ready for review May 23, 2019 07:00
@Neumann-A
Copy link
Copy Markdown
Contributor

would be good if upstream could provide a correct config/target file for this but that is probably too much to ask for ;)

@JackBoosY
Copy link
Copy Markdown
Contributor Author

@Neumann-A I agree with you.

@Rastaban Rastaban merged commit 9d62331 into microsoft:master May 24, 2019
@JackBoosY JackBoosY deleted the dev/jack/6479 branch May 24, 2019 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants