Merged
Conversation
* ebml: use standard CMake project * ebml: no patches needed (merged in upstream) * matroska: update to 1.5.0 * matroska: use standard CMake project Breaking changes from upstream: * ebml target is now in EBML:: namespace * matroska target is now in Matroska:: namespace
Contributor
Author
|
Installation: Test example build ( cmake_minimum_required(VERSION 3.0.0)
project(find_test VERSION 0.1.0)
set(CMAKE_BUILD_TYPE Debug)
foreach(flag_var
CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE
CMAKE_CXX_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_RELWITHDEBINFO
CMAKE_C_FLAGS CMAKE_C_FLAGS_DEBUG CMAKE_C_FLAGS_RELEASE
CMAKE_C_FLAGS_MINSIZEREL CMAKE_C_FLAGS_RELWITHDEBINFO)
if (${flag_var} MATCHES "/MD")
string (REGEX REPLACE "/MD" "/MT" ${flag_var} "${${flag_var}}")
endif ()
endforeach (flag_var)
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
set(CMAKE_VERBOSE_MAKEFILE ON)
find_package(Matroska CONFIG REQUIRED)
add_executable(find_test main.cpp)
target_link_libraries(find_test PRIVATE Matroska::matroska)Note |
This was referenced May 19, 2019
Contributor
|
Thanks for the PR!
|
evpobr
added a commit
to evpobr/libebml
that referenced
this pull request
May 21, 2019
Unix paths are case sensitive, but we use EbmlConfig.cmake.in & EBMLConfig.cmake.in. Related to Matroska-Org#44, microsoft/vcpkg#6526
Contributor
Contributor
Author
No idea what's happening. EBML library is configured, built and installed. |
Member
|
I reviewed the logs, there was an issue in our CI system. |
vicroms
force-pushed
the
ebml-and-matroska-update
branch
from
fa4f1f5 to
7762a9d
Compare
Member
|
@evpobr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes from upstream: