Skip to content

[azure] Update vcpkgs (add new port dependencies)#6511

Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom
ewertons:master
May 20, 2019
Merged

[azure] Update vcpkgs (add new port dependencies)#6511
ras0219-msft merged 3 commits intomicrosoft:masterfrom
ewertons:master

Conversation

@ewertons
Copy link
Contributor

No description provided.

@ewertons
Copy link
Contributor Author

In this PR we are adding some new submodules our solution depends on, plus providing fixes for building our solution using vcpkg TOOLCHAIN.

@ras0219-msft
Copy link
Contributor

Thanks for the PR!

The name umock-c doesn't look to be already in use by any other libraries, however it does seem very distinct from all the existing azure-xyz-c libraries. Are you sure you'd like to use that package name?

Side notes: I bumped the control versions and normalized the spacing. I'd also recommend using a branch for future PRs (instead of master), just to help keep things straight.

)
endif()

file(COPY ${CURRENT_INSTALLED_DIR}/share/azure-c-shared-utility/azure_iot_build_rules.cmake DESTINATION ${SOURCE_PATH}/deps/azure-c-shared-utility/configs/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ports must not write to the /installed folder directly.

Copy the file to ${CURRENT_PACKAGES_DIR} and it will be copied to the /installed directory when the installation is complete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks for the review. Yes, I fixed it and tested, it works good.
Please feel free to merge if the changes are good.
Thanks.

@vicroms
Copy link
Member

vicroms commented May 19, 2019

/AzurePipelines run

@ras0219-msft ras0219-msft merged commit e290fc4 into microsoft:master May 20, 2019
@ras0219-msft
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants