Skip to content

[armadillo]Fix usage error.#6474

Closed
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/5804
Closed

[armadillo]Fix usage error.#6474
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/5804

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented May 16, 2019

Add dependent port openblas.
Add vcpkg_configure_cmake options.

  • Fix share path error in linux.
  • Add dependent port clapack.

Relate: #5804.

@cenit
Copy link
Contributor

cenit commented May 16, 2019

BTW: Why is the macro VCPKG_CMAKE_SYSTEM_NAME is empty when running portfile.cmake?

mmm... this is really strange, since it is the correct way to understand the system on which you are running... (as I was saying in the review)

@JackBoosY
Copy link
Contributor Author

@cenit Yeah, I prefer to use VCPKG_CMAKE_SYSTEM_NAME to distinguish between different platforms.
Sometimes it works, sometimes it's empty.

@cenit
Copy link
Contributor

cenit commented May 16, 2019

when it's empty you are on Windows desktop. It just depends on your triplet :)

@JackBoosY
Copy link
Contributor Author

@cenit Clapack did not generate config.cmake file. So if I modify CMakeLists.txt and add find_package(clapack CONFIG REQUIRED) then port clapack will not be imported correctly.
And I found... we can just add clapack dependencies to solve this problem.

@cenit
Copy link
Contributor

cenit commented May 16, 2019

@cenit Clapack did not generate config.cmake file. So if I modify CMakeLists.txt and add find_package(clapack CONFIG REQUIRED) then port clapack will not be imported correctly.
And I found... we can just add clapack dependencies to solve this problem.

that's a problem I am trying to solve in #6371

@JackBoosY
Copy link
Contributor Author

@cenit In fact, if there is no port-config.cmake file, we can use find_library to solve the problem of finding the debug/release library path and use target_link_libraries to use the dependency library.

@cenit
Copy link
Contributor

cenit commented May 21, 2019

That’s exactly what I did in that PR :)

@JackBoosY
Copy link
Contributor Author

This issue has been fixed in #6371.

@JackBoosY JackBoosY closed this Jun 3, 2019
@JackBoosY JackBoosY deleted the dev/jack/5804 branch June 3, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants