Skip to content

[mathgl] draft port#6463

Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom
cenit:dev/cenit/mathgl
May 24, 2019
Merged

[mathgl] draft port#6463
ras0219-msft merged 2 commits intomicrosoft:masterfrom
cenit:dev/cenit/mathgl

Conversation

@cenit
Copy link
Copy Markdown
Contributor

@cenit cenit commented May 15, 2019

#6462 this is just a quick draft of a port. It builds on linux with default features, didn't check anything apart from it

Copy link
Copy Markdown
Contributor

@Neumann-A Neumann-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before you use file rename, remove pls make sure that the file exist.

@cenit cenit force-pushed the dev/cenit/mathgl branch from b01cd45 to 7b885b3 Compare May 20, 2019 15:10
@cenit
Copy link
Copy Markdown
Contributor Author

cenit commented May 20, 2019

@cbezault please let me know regressions. I hope @AntonioMiguel can try this PR, for me it's ready if there are no regressions

@AntonioMiguel
Copy link
Copy Markdown

vcpkg install mathgl:x64-windows

 works without any problem in windows 10 

Thanks cenit for your work

@cenit
Copy link
Copy Markdown
Contributor Author

cenit commented May 24, 2019

@cbezault any update? Looks like @AntonioMiguel is using the port successfully. Shall we merge?

@ras0219-msft
Copy link
Copy Markdown
Contributor

LGTM, thanks for the PR!

@ras0219-msft ras0219-msft merged commit ff77285 into microsoft:master May 24, 2019
@cenit cenit deleted the dev/cenit/mathgl branch May 31, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants