[Curl] Upgrades 2019.05.08#6429
Merged
ras0219-msft merged 9 commits intomicrosoft:masterfrom May 26, 2019
PhoebeHui:dev/Phoebe/UpgradeCurl_2019.05.08
Merged
[Curl] Upgrades 2019.05.08#6429ras0219-msft merged 9 commits intomicrosoft:masterfrom PhoebeHui:dev/Phoebe/UpgradeCurl_2019.05.08
ras0219-msft merged 9 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/UpgradeCurl_2019.05.08
Conversation
added 2 commits
May 14, 2019 14:50
Contributor
ras0219-msft
requested changes
May 16, 2019
Contributor
|
@ras0219-msft: A heads-up: CURL 7.64.1 breaks the This is fixed in the next version of CURL, which is scheduled for release 22nd of May 2019. (Note: This will require renaming the |
Contributor
|
CURL 7.65 is now available. Per the above, the |
Contributor
|
Thanks a bunch for the heads-up, @past-due! |
…L since we don't build the manual anyway.
past-due
reviewed
May 22, 2019
Member
|
ping @ras0219-msft Something holding this PR from merging? |
Contributor
|
No, LGTM. Thanks for the great work @PhoebeHui and the review @past-due! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR #6382
The new upgrade in Curl, it moved deprecated #define CURLE_SSL_CACERT CURLE_PEER_FAILED_VERIFICATION to ifndef block in commit 0fd4427f, we didn’t define CURL_NO_OLDIES, so the following code enabled:
#define CURLE_SSL_CACERT CURLE_PEER_FAILED_VERIFICATION
In cpr\error.cpp reference 2 cases that both have same case value, so it failed with ‘error C2196: case value '60' already used’.
case CURLE_PEER_FAILED_VERIFICATION:
return ErrorCode::SSL_REMOTE_CERTIFICATE_ERROR;
case CURLE_SSL_CACERT:
return ErrorCode::SSL_CACERT_ERROR;
So I removed one of them to fix it.