Skip to content

fix: Invalid character ('(') in a variable name: 'PROGRAMFILES'#6420

Merged
Rastaban merged 1 commit intomicrosoft:masterfrom
lukka:lukka/fixparens
May 13, 2019
Merged

fix: Invalid character ('(') in a variable name: 'PROGRAMFILES'#6420
Rastaban merged 1 commit intomicrosoft:masterfrom
lukka:lukka/fixparens

Conversation

@lukka
Copy link
Member

@lukka lukka commented May 13, 2019

CMake Warning (dev) at ..../vcpkg/scripts/buildsystems/vcpkg.cmake:133 (file):
Policy CMP0053 is not set: Simplify variable reference and escape sequence
evaluation. Run "cmake --help-policy CMP0053" for policy details. Use the
cmake_policy command to set the policy and suppress this warning.

For input:

'$ENV{PROGRAMFILES(x86)}'

the old evaluation rules produce:

'C:\Program Files (x86)'

but the new evaluation rules produce an error:

Syntax error in cmake code at
  ..../vcpkg/scripts/buildsystems/vcpkg.cmake:133
when parsing string
  $ENV{PROGRAMFILES(x86)}
Invalid character ('(') in a variable name: 'PROGRAMFILES'

Using the old result for compatibility since the policy is not set.

@Rastaban
Copy link
Contributor

Ug, I am going to go ahead an merge this to unbreak master even though modifications to this file does not force any real tests to run in the CI system.

@Rastaban Rastaban merged commit f2f3124 into microsoft:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants