[glm] Remove all unnecessary build steps#6410
Conversation
|
Hi @cwfitzgerald, thanks for your new PR. I see that the port globjects that depends on glm failed on all triplets. The port forge failed on x64-windows. Please check the changes again.
|
|
Thanks for the logs, I'll investigate the issue tomorrow. |
|
globjects failed because of a really stupid header export issue that exported everything inside the glm folder not the folder itself. |
|
I confirmed that this shouldn't break CMake users -- the existing glm port provides: |
|
👍 I don't know what is causing the CI to fail currently, but the outward effects of the port should be currently identical. |
|
This LGTM, thanks for the PR! |
#6461 the new port file does not export interface include directories (which for a header only library are maybe the only important thing)... @ras0219-msft edit: the CI was also clearly exposing it: |
|
Line 6 of the CMakeLists attaches the include directory into the exported
glm target. From the logs I was given, the headers not being found was
because I was exporting the headers, but not the containing folder, i.e.
`glm/fwd.hpp` was erroneously exported to `fwd.hpp`.
…On Wed, May 15, 2019, 12:11 Stefano Sinigardi ***@***.***> wrote:
I confirmed that this shouldn't break CMake users -- the existing glm port
provides:
The package glm:x86-windows provides CMake targets:
find_package(glm CONFIG REQUIRED)
target_link_libraries(main PRIVATE glm)
#6461 <#6461> the new port file
does not export interface include directories...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6410?email_source=notifications&email_token=AB37I2MO2U6ZAHQ2ZLG4NU3PVQY4DA5CNFSM4HMIZJZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVPFEKY#issuecomment-492720683>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB37I2LQSA3F7OTM6YTZL5TPVQY4DANCNFSM4HMIZJZQ>
.
|
|
The issue was that I've opened #6466 to fix this. |
|
Oh snap! Sorry about that!
…On Wed, May 15, 2019, 17:07 Robert Schumacher ***@***.***> wrote:
The issue was that include(GNUInstallDirs) was placed *after* the use of
CMAKE_INSTALL_INCLUDEDIR, so it wasn't defined yet.
I've opened #6466 <#6466> to fix
this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6410?email_source=notifications&email_token=AB37I2K7SN2FV4NJQJG2DIDPVR3SJA5CNFSM4HMIZJZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVP6NGQ#issuecomment-492824218>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB37I2NWATEV232XV5V3NCDPVR3SJANCNFSM4HMIZJZQ>
.
|
4 participants
GLM is a header only library. For some reason it builds static and shared libraries within its cmakelists but never actually installs them. In addition, the 160 test executables are unconditionally built with no option to disable them. I have replaced their complicated CMakeLists.txt with a barebones one that properly creates the exported target and copies the headers. Installation time for this header only library went from 3 minutes to 3 seconds.