[WIP] Find ports which do not correctly handle single configuration triplets#6368
Closed
Neumann-A wants to merge 13 commits intomicrosoft:masterfrom
Closed
[WIP] Find ports which do not correctly handle single configuration triplets#6368Neumann-A wants to merge 13 commits intomicrosoft:masterfrom
Neumann-A wants to merge 13 commits intomicrosoft:masterfrom
Conversation
Contributor
|
for OpenCV it's in the backlog of #5169, will fix this use case very soon in that PR |
Contributor
|
Contributor
Author
|
@Rastaban: I don't think these logs help here since the reason for the failure is in the portfile itself. Having the CI log output would be good, so that we can see where in the portfile the error occurred. The regressions here should probably be fixed in single PRs for faster merging and then also been merged into this branch. I never expected there to be so many regressions. |
Contributor
|
if you want some other nice surprises you should also try to put a fatal error in case of unmerged patch 🤣 |
Contributor
|
Here are the console logs of the CI build step in the pipline for all triplets: I agree that it is best to handle the fixes in smaller PRs. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cbezault
assigned
cbezault,
vicroms,
Rastaban,
PhoebeHui,
NancyLi1013,
JackBoosY and
dan-shaw
Contributor
|
If this PR is dead we should close it. |
Contributor
Author
|
@cbezault: This PR is not ment to be merged. It is more like a TODO list which ports must be fixed in master to support single configuration builds. Do with it whatever you like but keep in mind that those CI failing ports must still be fixed ;) |
Contributor
|
I wrote up an issue for this and will close this PR for now. If @Neumann-A is interested in working on this then the PR should be reopened, otherwise I think whoever works on it should open a similar draft PR for the purpose of testing (although maybe only do one triplet at a time to be lighter on the CI infrastructure). And then separate PRs for their fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intend:
find portfiles which do not handle single configuration triplets correctly by the regressions in the CI system.
Most common error in a portfile: