Skip to content

[gdcm]Update to v3.0.0 and rename to gdcm.#6348

Merged
Rastaban merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/gdcm_3.0.0
May 10, 2019
Merged

[gdcm]Update to v3.0.0 and rename to gdcm.#6348
Rastaban merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/gdcm_3.0.0

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented May 8, 2019

  • Update to v3.0.0
  • Rename this port name to gdcm because its version is no longer 2.x.x.
  • Fix dependencies.
  • Fix share path.
  • Add empty port gdcm2 mapping to gdcm.

Relate: #6338.

@JackBoosY
Copy link
Contributor Author

All the triplets are passed. CI failed because its name has changed.

@Rastaban
Copy link
Contributor

Rastaban commented May 9, 2019

I'm concered about breaking someone because we changed the name of the port, but I agree that gdcm is a better name. Could you bring back the gdcm2 port with a CONTROL file

Source: gdcm2
Version: deprecated
Description: This port was renamed to gdcm.  The gdcm2 name is deprecated.
Build-Depends: gdcm

portfile.cmake can just contain set(VCPKG_POLICY_EMPTY_PACKAGE enabled) along with a message about the port being renamed.

@JackBoosY
Copy link
Contributor Author

@Rastaban yeah, I agree with you. I added empty port gdcm2 mapping to gdcm.

@Rastaban Rastaban merged commit ddec717 into microsoft:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants