Skip to content

[gdal] fixed compilation issue with std::fabs#6336

Merged
Rastaban merged 5 commits intomicrosoft:masterfrom
jepessen:master
May 9, 2019
Merged

[gdal] fixed compilation issue with std::fabs#6336
Rastaban merged 5 commits intomicrosoft:masterfrom
jepessen:master

Conversation

@jepessen
Copy link
Contributor

@jepessen jepessen commented May 7, 2019

I had a compilation issue in ogr/ogrlinestring.cpp because std::fabs was not defined. I've added include file.

I'm using Windows 10 Professional, and build with Visual Studio 2017 and 2019

@msftclas
Copy link

msftclas commented May 7, 2019

CLA assistant check
All CLA requirements met.

@jumpinjackie
Copy link
Contributor

You should probably upstream this fix to https://github.com/OSGeo/gdal as well

@jepessen
Copy link
Contributor Author

jepessen commented May 8, 2019

I've created a pull request also in gdal repository.

@NancyLi1013
Copy link
Contributor

Hi @jepessen, thanks for your PR. Could you also bump the CONTROL version?

@jepessen
Copy link
Contributor Author

jepessen commented May 8, 2019

It should be ok. Where can I find some guideline about bumping version numbers? I didn't find anything about it...

@jumpinjackie
Copy link
Contributor

@jepessen You bump the number after the - to signal changes to the port. Pretty much any PR for ports that does not update to a new release version would require bumping the port version number.

Source: My observations from submitted PRs :)

@jepessen
Copy link
Contributor Author

jepessen commented May 8, 2019

Ok thanks for the info. I'll take care of it in future merges.

@Rastaban
Copy link
Contributor

Rastaban commented May 9, 2019

@jepessen incrementing the control verson helps with the vcpkg upgrade command. The policy is buried with the documentation for the CONTROL file in control-files.md and is admitadly very easy to miss.

@Rastaban Rastaban merged commit e2f4566 into microsoft:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants