Skip to content

[minhook] Add new port#6333

Merged
grdowns merged 5 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/2043
May 8, 2019
Merged

[minhook] Add new port#6333
grdowns merged 5 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/2043

Conversation

@NancyLi1013
Copy link
Contributor

The related issue #2043.
The port only supports x64 or x86 for windows.

@grdowns grdowns self-assigned this May 7, 2019
@grdowns
Copy link
Contributor

grdowns commented May 8, 2019

Hey @NancyLi1013, thanks for the new port. I opted to download the CMake support files as a patch, that way the original author is referenced for the work they did. I also created a second patch that fixes up the destination directories to suit our needs. Lastly I moved the architecture check to before we do any costly work -- this way the user won't have to download the source code and extract it before finding out that the port is not supported for their architecture. Otherwise this looks great; I'll be able to merge it as soon as it goes through the CI. Thanks again!

@grdowns grdowns merged commit 5121e71 into microsoft:master May 8, 2019
@Mixaill
Copy link
Contributor

Mixaill commented May 21, 2019

@grdowns AFAIK, there is vcpkg_fixup_cmake_targets which moves content from lib/<port> to share/<port>. I think this way is more preferable than CMakeLists.txt patching.

also, .patch contains author name, so it should be OK to place it directly in port directory :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants