Skip to content

[libnoise] Add new port libnoise#6319

Merged
vicroms merged 2 commits intomicrosoft:masterfrom
RobertHue:master
May 6, 2019
Merged

[libnoise] Add new port libnoise#6319
vicroms merged 2 commits intomicrosoft:masterfrom
RobertHue:master

Conversation

@RobertHue
Copy link
Contributor

@RobertHue RobertHue commented May 5, 2019

I added a port to libnoise: (request: #6274)
fixed some bugs inside pull reqeuest #6297

Source: libnoise
Version: 1.0.0
Description: A general-purpose library that generates three-dimensional coherent noise. Useful for terrain generation and procedural texture generation. Uses a broad number of techniques (Perlin noise, ridged multifractal, etc.) and combinations of those techniques.

tested with following compilers/triplets:

x86-windows
x64-windows
x86-windows-static
x64-windows-static

REPO:

RobertHue/libnoise

Between:
How to add a new pull request onto some old request?

@vicroms
Copy link
Member

vicroms commented May 6, 2019

HI @RobertHue

Thanks for your contribution!

libnoise builds for all triplets in our CI system. and could be merged as it is. But, I think we can do better.
Would you be kind enough to remove all the commented lines in the portfile.cmake file?

@vicroms vicroms self-assigned this May 6, 2019
@vicroms vicroms merged commit ce6dbe7 into microsoft:master May 6, 2019
@vicroms
Copy link
Member

vicroms commented May 6, 2019

Merged. Thanks for contributing!

@cenit
Copy link
Contributor

cenit commented Nov 10, 2021

#21235

we added this port using the fork by the user that did the PR.
A fork on top of another fork, which provides a cmake module that is broken for downstream users. Now downstream users are complaining.

shall we revert to official repo and maybe provide ourselves a cmake build script (that exports configs, instead of creating also a module) in case the official build is not working on windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants