Skip to content

[xproperty] Add new port#6316

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
myd7349:xproperty-init
May 21, 2019
Merged

[xproperty] Add new port#6316
vicroms merged 1 commit intomicrosoft:masterfrom
myd7349:xproperty-init

Conversation

@myd7349
Copy link
Contributor

@myd7349 myd7349 commented May 5, 2019

@myd7349 myd7349 changed the title [xproperty] Add new port [WIP][xproperty] Add new port May 5, 2019
@vicroms
Copy link
Member

vicroms commented May 6, 2019

Builds successfully for all triplets in CI.
I think it is OK to merge, what do you think @myd7349 ?

@vicroms vicroms self-assigned this May 6, 2019
@myd7349
Copy link
Contributor Author

myd7349 commented May 7, 2019

Hi! @vicroms I am waiting on this PR: jupyter-xeus/xproperty#40. If this patch is merged in the upstream, I can remove fix-target.patch used under this PR.

@vicroms vicroms added the wip label May 7, 2019
@vicroms vicroms merged commit ed61238 into microsoft:master May 21, 2019
@myd7349 myd7349 deleted the xproperty-init branch May 21, 2019 00:36
@myd7349 myd7349 changed the title [WIP][xproperty] Add new port [xproperty] Add new port May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants