Skip to content

[libpng] remove broken patch#6293

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
cenit:dev/cenit/libpng
May 7, 2019
Merged

[libpng] remove broken patch#6293
vicroms merged 1 commit intomicrosoft:masterfrom
cenit:dev/cenit/libpng

Conversation

@cenit
Copy link
Contributor

@cenit cenit commented May 3, 2019

No description provided.

@vicroms vicroms self-assigned this May 3, 2019
@NancyLi1013
Copy link
Contributor

Hi @cenit, I see that qt5-3d failed on x86-windows from the current CI system.
The error likes this:
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:56 (message):
Command failed: C:/vsts/_work/2/s/downloads/tools/jom/jom-1.1.3/jom.exe
Working Directory: C:/vsts/_work/2/s/buildtrees/qt5-3d/x86-windows-rel
Error code: 2
See logs for more information:
C:\vsts_work\2\s\buildtrees\qt5-3d\package-build-x86-windows-rel-out.log
C:\vsts_work\2\s\buildtrees\qt5-3d\package-build-x86-windows-rel-err.log
failureLogs.zip

@cenit
Copy link
Contributor Author

cenit commented May 5, 2019

This one is really curious, I will investigate it soon (I didn’t open the zip as of now): this PR technically should not change anything, since it adds “unused” targets (make the port more future-proof) and removes a patch that was impossible to apply because it was broken with recent sources... I was expecting an “easy” green mark!

@vicroms
Copy link
Member

vicroms commented May 6, 2019

@cenit were you able to get a repro?
I was unable to get one locally.

@cenit
Copy link
Contributor Author

cenit commented May 7, 2019

@vicroms No sorry. Too much busy

@vicroms vicroms merged commit d60f874 into microsoft:master May 7, 2019
@cenit cenit deleted the dev/cenit/libpng branch May 8, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants