[moos-core]Fix build failure on Windows#6252
Merged
grdowns merged 6 commits intomicrosoft:masterfrom May 7, 2019
JackBoosY:dev/jack/5594
Merged
[moos-core]Fix build failure on Windows#6252grdowns merged 6 commits intomicrosoft:masterfrom JackBoosY:dev/jack/5594
grdowns merged 6 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/5594
Conversation
1.Add compile macros and includes 2.Fix empty directories in static.
Contributor
Author
|
Hi @pmnewman, can you help me see if I am correct? |
grdowns
suggested changes
Apr 29, 2019
grdowns
approved these changes
May 7, 2019
Contributor
|
Hey @JackBoosY, the changes look good. I cleaned up some of the tool copying as we don't install any binaries in the bin/ directory due to disabling the dynamic builds, and I removed the extra messaging and simplified the license installation. Thanks for the update! |
Contributor
Author
|
@grdowns thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps:
See #5594