Skip to content

Fix sdl2 dependents#6199

Closed
cbezault wants to merge 1 commit intomicrosoft:masterfrom
cbezault:fix_sdl2_rebase
Closed

Fix sdl2 dependents#6199
cbezault wants to merge 1 commit intomicrosoft:masterfrom
cbezault:fix_sdl2_rebase

Conversation

@cbezault
Copy link
Contributor

Resolves #6152.

@microsoft microsoft deleted a comment from azure-pipelines bot Apr 24, 2019
@microsoft microsoft deleted a comment from azure-pipelines bot Apr 24, 2019
@microsoft microsoft deleted a comment from azure-pipelines bot Apr 24, 2019
@grdowns
Copy link
Contributor

grdowns commented Apr 24, 2019

Perhaps it might be best to write this into the vcpkg_cmake_wrapper.cmake to populate SDL_LIBRARY from SDL_LIBRARY_RELEASE and SDL_LIBRARY_DEBUG so that less ports have to be touched by this? It might also aid authoring ports in the future.

EDIT: Nevermind, this pattern is quite prevalent.

@Neumann-A
Copy link
Contributor

The patch should use find_package instead of find_library.
SDL2 exports targets and linking against those is probably desirable.

@cbezault
Copy link
Contributor Author

@Neumann-A, I agree, thanks for taking a look.

@cbezault
Copy link
Contributor Author

Same as #5948

@cbezault cbezault closed this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The release build of SDL2-image depends on the debug build of SDL2

3 participants