Updated ISMRMRD to the latest versions#6111
Merged
grdowns merged 1 commit intomicrosoft:masterfrom May 23, 2019
Merged
Conversation
Contributor
|
Hi @dchansen, here are the test results from the current CI system:
|
…uld not be optional on platforms with HDF5 available
Contributor
Author
|
Is this ok to merge now? It would make the life our our users immensely easier if they could simply install through VCPKG, but the current port someone created is quite broken. |
Contributor
|
Hey @dchansen! Sorry for the long wait, and thanks for fixing the merge conflicts that arose during that time. I wanted to make some small changes to disable the test and example building as opposed to allowing them to build and deleting them, but it's fine for now. Thanks for the update and fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed unwanted executalbes produced when FFTW is found