Skip to content

[g3log] Add new port#5961

Merged
cbezault merged 7 commits intomicrosoft:masterfrom
myd7349:g3log-init
May 14, 2019
Merged

[g3log] Add new port#5961
cbezault merged 7 commits intomicrosoft:masterfrom
myd7349:g3log-init

Conversation

@myd7349
Copy link
Contributor

@myd7349 myd7349 commented Apr 5, 2019

Test project: https://github.com/myd7349/Ongoing-Study/tree/master/cpp/CMake/vcpkg/g3log_example

Test on:

  • x86-windows
  • x86-windows-static
  • x64-windows
  • x64-windows-static
  • x64-linux
  • x64-osx

Known issues:

  • Failed to install on UWP: build-x86-uwp-dbg-out.log (even I specify -DENABLE_VECTORED_EXCEPTIONHANDLING=OFF)
  • target_link_libraries(${example_name} PRIVATE g3logger) doesn't work for me

@myd7349 myd7349 changed the title [g3log] Add new port [WIP][g3log] Add new port Apr 6, 2019
@NancyLi1013
Copy link
Contributor

Hi @myd7349, thanks for your contribution to vcpkg. Here are the test results from the current CI system:

x64-windows master test notes
g3log Pass New Port
x64-windows-static master test notes
g3log Pass New Port
x64-osx master test notes
g3log Pass New Port
arm64-windows master test notes
g3log Fail New Port
x86-windows master test notes
g3log Pass New Port
x64-linux master test notes
g3log Pass New Port
x64-uwp master test notes
g3log Fail New Port
arm-uwp master test notes
g3log Fail New Port

@NancyLi1013
Copy link
Contributor

The port failed on arm and uwp. Are those expected?

@myd7349
Copy link
Contributor Author

myd7349 commented Apr 11, 2019

Hi! @NancyLi1013 Yeah! These failures are as expected.
The reason I marked this port as WIP is that I have created a PR in the upstream repo to fix some issues and I am just waiting on it.

@grdowns grdowns self-assigned this Apr 12, 2019
@grdowns grdowns added the wip label Apr 12, 2019
@myd7349 myd7349 changed the title [WIP][g3log] Add new port [g3log] Add new port May 14, 2019
@myd7349
Copy link
Contributor Author

myd7349 commented May 14, 2019

OK. The WIP tag is removed.

@cbezault cbezault merged commit 03b364f into microsoft:master May 14, 2019
@myd7349 myd7349 deleted the g3log-init branch May 14, 2019 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants