[vcpkg] Fix infinite loop bug on certain filesystem implementations when searching up#5679
Merged
Rastaban merged 1 commit intomicrosoft:masterfrom Mar 15, 2019
Conversation
Contributor
|
This change looks okay to me. Is there an issue that this resolves or did you just notice the behavior when experimenting? |
Contributor
|
@Rastaban Can confirm. I have the same issue with VS 15.9.9, CL 19.16.27027.1. The infinite loop bug only happens when you execute Tested the patch - it solved the problem. |
Contributor
|
Thanks @qis. I'm okay if there is not a issue number for it, I just want to make sure that if there is a issue it will get closed when this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.