Skip to content

[capnproto] Add Capnproto package#5617

Merged
Rastaban merged 3 commits intomicrosoft:masterfrom
tarcila:master
Mar 26, 2019
Merged

[capnproto] Add Capnproto package#5617
Rastaban merged 3 commits intomicrosoft:masterfrom
tarcila:master

Conversation

@tarcila
Copy link
Contributor

@tarcila tarcila commented Mar 10, 2019

Add a new CapnProto package. Tested on Windows and Linux (Ubuntu 18.10).
The embedded patch as also been submitted upstream (capnproto/capnproto#804)

@msftclas
Copy link

msftclas commented Mar 10, 2019

CLA assistant check
All CLA requirements met.

HEAD_REF master
)

vcpkg_apply_patches(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved into the PATCHES argument to vcpkg_from_github

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rastaban Rastaban changed the title Add Capnproto package [capnproto] Add Capnproto package Mar 11, 2019
@Rastaban
Copy link
Contributor

This is looking good so far. It looks like the uwp failures are expected so those can be ignored. I also see failures arm64-windows is that expected?

@tarcila
Copy link
Contributor Author

tarcila commented Mar 11, 2019

This is looking good so far. It looks like the uwp failures are expected so those can be ignored.

Yes, for uwp, the code relies on some LoadLibrary calls, so this is a no go.

I also see failures arm64-windows is that expected?

Not sure about this one. I can't seem to have access to build logs. Anything you can share?
The original website does make mention of C++11 compatibility, a quick search did not bring more details.

@tarcila
Copy link
Contributor Author

tarcila commented Mar 11, 2019

I have pushed an updated version that address PATCHES comment, plus some cmake related cleanups.

Once #5630 is merged, this should make the vcpkg_test_cmake() statement work correctly on currently broken Linux and OSX.

@Rastaban Rastaban self-assigned this Mar 13, 2019
@Rastaban
Copy link
Contributor

With the latest commit I see failures on everything except x86-windows.

Starting package 2/2: capnproto:x64-windows
Building package capnproto[core]:x64-windows... 
Could not locate cached archive: C:\vsts\_work\1\s\archives\b3\b3fd7d6ae526f020b8ca476d47d0431257398d86.zip
Building DLLs not supported. Building static instead.
-- Downloading https://github.com/capnproto/capnproto/archive/v0.7.0.tar.gz...
-- Extracting source C:/vsts/_work/1/s/downloads/capnproto-capnproto-v0.7.0.tar.gz
-- Applying patch C:/vsts/_work/1/s/ports/capnproto/0001-fix-capnpc-extension-handling-on-Windows.patch
-- Using source at C:/vsts/_work/1/s/buildtrees/capnproto/src/v0.7.0-b4a52715c4
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Performing CMake integration test
CMake Error at scripts/cmake/vcpkg_test_cmake.cmake:56 (message):
  CMake integration test failed; unable to find_package(CapnProto CONFIG
  REQUIRED)
Call Stack (most recent call first):
  ports/capnproto/portfile.cmake:39 (vcpkg_test_cmake)
  scripts/ports.cmake:71 (include)


Error: Building package capnproto:x64-windows failed with: BUILD_FAILED
Elapsed time for package capnproto:x64-windows: 3.784 min

Log files:
capmproto_2484052.zip

@tarcila
Copy link
Contributor Author

tarcila commented Mar 13, 2019

Thanks for the logs. Most of the failures are for now expected, waiting for a few fixes:

Checking for the logs, arm64 failures seem related to upstream code being incompatible with the target platform (__popcnt intrinsic)

@Rastaban Rastaban added the wip label Mar 20, 2019
@tarcila
Copy link
Contributor Author

tarcila commented Mar 22, 2019

@Rastaban I can remove the cmake integration test from the package. That would make the package fully functional, but only on Windows (x86 and x64). Would it be an acceptable solution?

It would later on be fixed on Linux and OSX when #5630 is integrated and cmake integration test could be added back once #5635 is fixed.

@Rastaban
Copy link
Contributor

@tarcila that sounds good to me. Having it in and functional for some architectures is more useful than none.

Integration test is failing for now because of microsoft#5630 and microsoft#5635
This at least makes the package function on Windows x86 and x64.
@Rastaban Rastaban merged commit 6b0ab19 into microsoft:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants