[capnproto] Add Capnproto package#5617
Conversation
ports/capnproto/portfile.cmake
Outdated
| HEAD_REF master | ||
| ) | ||
|
|
||
| vcpkg_apply_patches( |
There was a problem hiding this comment.
This can be moved into the PATCHES argument to vcpkg_from_github
|
This is looking good so far. It looks like the uwp failures are expected so those can be ignored. I also see failures arm64-windows is that expected? |
Yes, for uwp, the code relies on some LoadLibrary calls, so this is a no go.
Not sure about this one. I can't seem to have access to build logs. Anything you can share? |
|
I have pushed an updated version that address Once #5630 is merged, this should make the vcpkg_test_cmake() statement work correctly on currently broken Linux and OSX. |
|
With the latest commit I see failures on everything except x86-windows. Log files: |
|
Thanks for the logs. Most of the failures are for now expected, waiting for a few fixes:
Checking for the logs, arm64 failures seem related to upstream code being incompatible with the target platform (__popcnt intrinsic) |
|
@Rastaban I can remove the cmake integration test from the package. That would make the package fully functional, but only on Windows (x86 and x64). Would it be an acceptable solution? It would later on be fixed on Linux and OSX when #5630 is integrated and cmake integration test could be added back once #5635 is fixed. |
|
@tarcila that sounds good to me. Having it in and functional for some architectures is more useful than none. |
Integration test is failing for now because of microsoft#5630 and microsoft#5635 This at least makes the package function on Windows x86 and x64.
Add a new CapnProto package. Tested on Windows and Linux (Ubuntu 18.10).
The embedded patch as also been submitted upstream (capnproto/capnproto#804)