Skip to content

[xalan-c] Use CMake build system, enables linux/mac build#5399

Closed
seanwarren wants to merge 1 commit intomicrosoft:masterfrom
seanwarren:xalanc-cmake-build
Closed

[xalan-c] Use CMake build system, enables linux/mac build#5399
seanwarren wants to merge 1 commit intomicrosoft:masterfrom
seanwarren:xalanc-cmake-build

Conversation

@seanwarren
Copy link
Copy Markdown
Contributor

This PR updates the xalan-c port to uses the CMake build written by @rleigh-codelibre (see https://jira.apache.org/jira/browse/XALANC-776).

This enables building xalan-c on mac and linux under vcpkg.

Two patches (#8 and #9) have been pulled directly into the port.

@rleigh-codelibre
Copy link
Copy Markdown
Contributor

While I'm happy for this to be included, please note that it has not had the same level of rigourous testing which the Xerces-C++ CMake build has had. Please do check that the library names and exported ABI is identical to the existing msbuild project and solution file output before making the change, or else it could result in breakage.

In the next few months, I should be accepted onto the PMC for Xalan, at which point I'll be able to merge the entire patchset, plus the CMake build, and make a new upstream release. This will permit these patchset to be dropped.

Thanks,
Roger

@seanwarren
Copy link
Copy Markdown
Contributor Author

Hi Roger, if there is a plan for these changes to be merged upstream it's probably worth waiting for that.

Cheers
Sean

@seanwarren seanwarren closed this Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants