[xalan-c] Use CMake build system, enables linux/mac build#5399
Closed
seanwarren wants to merge 1 commit intomicrosoft:masterfrom
Closed
[xalan-c] Use CMake build system, enables linux/mac build#5399seanwarren wants to merge 1 commit intomicrosoft:masterfrom
seanwarren wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
While I'm happy for this to be included, please note that it has not had the same level of rigourous testing which the Xerces-C++ CMake build has had. Please do check that the library names and exported ABI is identical to the existing msbuild project and solution file output before making the change, or else it could result in breakage. In the next few months, I should be accepted onto the PMC for Xalan, at which point I'll be able to merge the entire patchset, plus the CMake build, and make a new upstream release. This will permit these patchset to be dropped. Thanks, |
Contributor
Author
|
Hi Roger, if there is a plan for these changes to be merged upstream it's probably worth waiting for that. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the xalan-c port to uses the CMake build written by @rleigh-codelibre (see https://jira.apache.org/jira/browse/XALANC-776).
This enables building xalan-c on mac and linux under vcpkg.
Two patches (#8 and #9) have been pulled directly into the port.