[spirv-tools] install executables on linux and macos#5373
Merged
Codiferous merged 1 commit intomicrosoft:masterfrom Feb 15, 2019
jhs67:spirv-tools
Merged
[spirv-tools] install executables on linux and macos#5373Codiferous merged 1 commit intomicrosoft:masterfrom jhs67:spirv-tools
Codiferous merged 1 commit intomicrosoft:masterfrom
jhs67:spirv-tools
Conversation
Contributor
|
The change looks good -- tested on Windows! 😄 Thanks for this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linux and macos version of this port fail to install the generated executables into the tools directory because of the hard coded windows executable extension. This patch uses the CMAKE_EXECUTABLE_SUFFIX variable to make this work on linux and macos. I don't have ready access to a windows machine to test this, but it should be a no-op on that platform.