[tiff] Disable libwebp support.#5348
Merged
vicroms merged 2 commits intomicrosoft:masterfrom Feb 14, 2019
Merged
Conversation
Since version 4.0.10, libtiff supports optional compression modes using either libweb or zstd. When libtiff is built, and libwebp and/or zstd are found anywhere on the system, these modes will be enabled. However, the respective libraries are not added as link targets, so this will result in linker errors for any unsuspecting project using libtiff. Since zstd support was already disabled by a previous commit, I have also simply disabled libwebp support to fix this issue. A more proper fix might be to add both libwebp and zstd as required libtiff dependencies, and to patch libtiff's CMakeLists.txt, such that these libraries are properly linked to. However, it is currently very unlikely to encounter TIFF images in the wild compressed using either of these methods, so the effect of disabling support may not be noticeable at all.
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 4.0.10, libtiff supports optional compression modes using
either libweb or zstd.
When libtiff is built, and libwebp and/or zstd are found anywhere on the
system, these modes will be enabled. However, the respective libraries
are not added as link targets, so this will result in linker errors for
any unsuspecting project using libtiff.
Since zstd support was already disabled by a previous commit, I have
also simply disabled libwebp support to fix this issue.
A more proper fix might be to add both libwebp and zstd as required
libtiff dependencies, and to patch libtiff's CMakeLists.txt, such that
these libraries are properly linked to. However, it is currently very
unlikely to encounter TIFF images in the wild compressed using either
of these methods, so the effect of disabling support may not be
noticeable at all.