Fix double-conversion issue in ITK by dzenanz · Pull Request #5115 · microsoft/vcpkg

dzenanz · 2019-01-09T21:06:46Z

Fixed by InsightSoftwareConsortium/ITK/pull/366. Closes google/double-conversion#85. Closes #4334. ITK is still not properly compiling due to an out-of-date version of HDF5.

PhoebeHui · 2019-03-06T07:07:31Z

@dzenanz, thanks for contributing to vcpkg!

Here is failed triplet(x64-uwp) and ports with your PR.

 Processing arm-uwp                        407 vs 407
 Processing arm64-windows                  458 vs 458
 Processing x64-linux                      595 vs 595
 Processing x64-osx                        587 vs 587
 Processing x64-uwp                        398 vs 435
     ffmpeg                        **regression**                Fail vs Pass
     forest                        **regression**                Fail vs Pass
      libvpx                       **regression**                Fail vs Pass
     socket-io-client              **regression**                Fail vs Pass
     spdlog                        **regression**                Fail vs Pass
     tinyspline                    **regression**                Fail vs Pass
     x264                          **regression**                Fail vs Pass
 Processing x64-windows                    850 vs 850
 Processing x64-windows-static             767 vs 767
 Processing x86-windows                    830 vs 830

dzenanz · 2019-03-06T15:38:00Z

I cannot see the details of Vcpkg-PR-Eager:

Sorry, but Dženan Zukić (Microsoft account) is not authorized to access this page
...
TF400813: The user 'Windows Live ID\dzenanz@hotmail.com' is not authorized to access this resource.

Also, ITK pretty much has nothing to do with ffmpg and x264. And I don't even recognize the names of the other libraries.

PhoebeHui · 2019-03-07T03:21:38Z

@dzenanz, the logs here may be incorrect, could you also update CONTROL revision in
https://github.com/Microsoft/vcpkg/blob/master/ports/itk/CONTROL? I will check the latest results and post here.

See more information in https://github.com/Microsoft/vcpkg/blob/master/docs/maintainers/control-files.md

Neumann-A · 2019-03-08T16:08:05Z

try #5574 for and updated version of HDF5

dzenanz · 2019-03-08T16:57:53Z

If I rebase on top of that, I still get:

C:\Dev\vcpkg\buildtrees\itk\ITK\Modules\IO\HDF5\src\itkHDF5ImageIO.cxx(1176): fatal error C1189: #error:  The selected version of HDF5 library does not support setting backwards compatibility at run-time.  Please use a different version of HDF5, e.g. the one bundled with ITK (by setting ITK_USE_SYSTEM_HDF5 to OFF).
C:\Dev\vcpkg\buildtrees\itk\ITK\Modules\ThirdParty\MINC\src\libminc\libsrc2\volume.c(120): error C2065: 'H5F_LIBVER_V18': undeclared identifier
C:\Dev\vcpkg\buildtrees\itk\ITK\Modules\ThirdParty\MINC\src\libminc\libsrc2\volume.c(223): error C2065: 'H5F_LIBVER_V18': undeclared identifier

Neumann-A · 2019-03-08T20:43:18Z

@dzenanz: Looking at the version check of ITK:
#if (H5_VERS_MAJOR>1) || (H5_VERS_MAJOR==1)&&(H5_VERS_MINOR>10) || (H5_VERS_MAJOR==1)&&(H5_VERS_MINOR==10)&&(H5_VERS_RELEASE>=2)
and looking at the version defined in hdf5config:

set (HDF5_VERSION_STRING 1.10.5)
set (HDF5_VERSION_MAJOR  1.10)
set (HDF5_VERSION_MINOR  5)

concerning:
C:\Dev\vcpkg\buildtrees\itk\ITK\Modules\ThirdParty\MINC\src\libminc\libsrc2\volume.c(223): error C2065: 'H5F_LIBVER_V18': undeclared identifier
I smell a missing target_link_libraries()

So lets see what ITK does.

First:

# Configuring locations of the libraries from ITK
# TODO: check if the ITK module is enabled
set(ZLIB_FOUND ON)
set(HDF5_FOUND ON)

next:
set(HDF5_LIBRARIES ${ITKHDF5_LIBRARIES})

  SET(HDF5_NO_FIND_PACKAGE_CONFIG_FILE ON)
  FIND_PACKAGE(HDF5 REQUIRED COMPONENTS C )

Lets see what FindHDF5 does with that (from cmake):
skipped: if(NOT HDF5_FOUND AND NOT HDF5_NO_FIND_PACKAGE_CONFIG_FILE) (thats already bad because and installed config is not used...)
skipped: if(NOT HDF5_FOUND) (and all other also check for HDF5_FOUND)
(So this does basiclly nothing....)

so what das libminc do:
TARGET_LINK_LIBRARIES(${LIBMINC_LIBRARY} ${HDF5_LIBRARIES} ${NIFTI_LIBRARIES} ${ZLIB_LIBRARY} ${RT_LIBRARY}) #
${HDF5_LIBRARIES} is always set to ${ITKHDF5_LIBRARIES}.

and that is set to

  if(BUILD_SHARED_LIBS)
    list(APPEND ITKHDF5_LIBRARIES ${HDF5_C_SHARED_LIBRARY} ${HDF5_CXX_SHARED_LIBRARY})
  else()
    list(APPEND ITKHDF5_LIBRARIES ${HDF5_C_STATIC_LIBRARY} ${HDF5_CXX_STATIC_LIBRARY})
  endif()

the shared variables are a empty the static are filled

but before that: This code is doing some magic:

  if(HDF5_DIR)
    # When ITK's config is loaded, load HDF5 too.
    set(ITKHDF5_EXPORT_CODE_INSTALL "
set(HDF5_DIR \"${HDF5_DIR}\")
find_package(HDF5 REQUIRED NO_MODULE)
")
    set(ITKHDF5_EXPORT_CODE_BUILD "
if(NOT ITK_BINARY_DIR)
  set(HDF5_DIR \"${HDF5_DIR}\")
  find_package(HDF5 REQUIRED NO_MODULE)
endif()
")

It is actually pulling in HDF5 with a find_package call what the code is not intending to do. It wants to set ITKHDF5_EXPORT_CODE_INSTALL and ITKHDF5_EXPORT_CODE_BUILD but is actually also doing the find_package call to HDF5. Before it none of ${HDF5_C_SHARED_LIBRARY} ${HDF5_CXX_SHARED_LIBRARY} ${HDF5_C_STATIC_LIBRARY} ${HDF5_CXX_STATIC_LIBRARY} are set. Should have probably used [[]] instead of "". One thing i did not find out why HDF5_DIR is set. Probably something to do with itk_module_init because I could see it being set in a config.in file.

Lets conclude: That is a holy cmake mess.... How should one maintain such a monster?
and BUILD_SHARED_LIBS should probably be defined for non static builds to link against dynamic hdf5.
Also itk seems to mix SYSTEM HDF5 and ITKHDF5. From my understanding H5_VERS_MAJOR shouldn't be set if you use system hdf5 but for me itk builds:

D:\vcpkg_test\vcpkg>vcpkg install itk:x64-windows --head
Your feedback is important to improve Vcpkg! Please take 3 minutes to complete our survey by running: vcpkg contact --survey
The following packages will be built and installed:
    itk[core]:x64-windows (from HEAD)
Starting package 1/1: itk:x64-windows
Building package itk[core]:x64-windows from HEAD...
-- Downloading https://api.github.com/repos/InsightSoftwareConsortium/ITK/git/refs/heads/master...
-- Skipping hash check for D:/vcpkg_test/vcpkg/downloads/temp/InsightSoftwareConsortium-ITK-master.tar.gz.version.
-- Downloading https://github.com/InsightSoftwareConsortium/ITK/archive/master.tar.gz...
-- Skipping hash check for D:/vcpkg_test/vcpkg/downloads/temp/InsightSoftwareConsortium-ITK-master.tar.gz.
-- Extracting source D:/vcpkg_test/vcpkg/downloads/InsightSoftwareConsortium-ITK-master.tar.gz
-- Using source at D:/vcpkg_test/vcpkg/buildtrees/itk/src/head/master-2d26731135
-- Configuring x64-windows-dbg
-- Configuring x64-windows-rel
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Performing post-build validation
The /lib/cmake folder should be merged with /debug/lib/cmake and moved to /share/itk/cmake.
The following cmake files were found outside /share/itk. Please place cmake files in /share/itk.

    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/lib/cmake/ITK-5.0/Modules/Eigen3Config.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/lib/cmake/ITK-5.0/Modules/Eigen3ConfigVersion.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/lib/cmake/ITK-5.0/Modules/Eigen3Targets.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Config.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3ConfigVersion.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Targets.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/debug/lib/cmake/ITK-5.0/Modules/Eigen3Config.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/debug/lib/cmake/ITK-5.0/Modules/Eigen3ConfigVersion.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/debug/lib/cmake/ITK-5.0/Modules/Eigen3Targets.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/debug/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Config.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/debug/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3ConfigVersion.cmake
    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/debug/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Targets.cmake

The /debug/lib/cmake folder should be merged with /lib/cmake into /share/itk
The following files are placed in
D:\vcpkg_test\vcpkg\packages\itk_x64-windows:

    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/vcl_compiler_detection.h

Files cannot be present in those directories.

The following files are placed in
D:\vcpkg_test\vcpkg\packages\itk_x64-windows\debug:

    D:/vcpkg_test/vcpkg/packages/itk_x64-windows/debug/vcl_compiler_detection.h

Files cannot be present in those directories.

Found 5 error(s). Please correct the portfile:
    D:\vcpkg_test\vcpkg\ports\itk\portfile.cmake
-- Performing post-build validation done
Error: Building package itk:x64-windows failed with: POST_BUILD_CHECKS_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: itk:x64-windows
  Vcpkg version: 2018.11.23-nohash

Additionally, attach any relevant sections from the log files above.

D:\vcpkg_test\vcpkg>git status
On branch VTK_8.2.0

My Branch VTK_8.2.0 does not include commit aa560f1

dzenanz · 2019-03-08T21:26:08Z

Oh, I needed to run vcpkg upgrade to get the updated HDF5. But after that I get similar result to you:

$ ./vcpkg install itk[vtk]
The following packages will be built and installed:
    itk[core,vtk]:x64-windows-static
Starting package 1/1: itk:x64-windows-static
Building package itk[core,vtk]:x64-windows-static...
-- Using cached C:/Dev/vcpkg/downloads/InsightSoftwareConsortium-ITK-616a3128cc38dcedba2620612822c4a2bbb2e36f.tar.gz
-- Using source at C:/Dev/vcpkg/buildtrees/itk/src/a2bbb2e36f-7e3c104bcb
-- Configuring x64-windows-static-dbg
-- Configuring x64-windows-static-rel
-- Building x64-windows-static-dbg
-- Building x64-windows-static-rel
-- Performing post-build validation
The /lib/cmake folder should be merged with /debug/lib/cmake and moved to /share/itk/cmake.
The following cmake files were found outside /share/itk. Please place cmake files in /share/itk.

    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/Eigen3Config.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/Eigen3ConfigVersion.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/Eigen3Targets.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Config.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3ConfigVersion.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Targets.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/Eigen3Config.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/Eigen3ConfigVersion.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/Eigen3Targets.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Config.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3ConfigVersion.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Targets.cmake

The /debug/lib/cmake folder should be merged with /lib/cmake into /share/itk
The following files are placed in
C:\Dev\vcpkg\packages\itk_x64-windows-static:

    C:/Dev/vcpkg/packages/itk_x64-windows-static/vcl_compiler_detection.h

Files cannot be present in those directories.

The following files are placed in
C:\Dev\vcpkg\packages\itk_x64-windows-static\debug:

    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/vcl_compiler_detection.h

Files cannot be present in those directories.

Found 5 error(s). Please correct the portfile:
    C:\Dev\vcpkg\ports\itk\portfile.cmake
-- Performing post-build validation done
Error: Building package itk:x64-windows-static failed with: POST_BUILD_CHECKS_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: itk:x64-windows-static
  Vcpkg version: 2018.11.23-nohash

Additionally, attach any relevant sections from the log files above.

vcl_compiler_detection.h-related issue might be caused by a recent fix (vxl/vxl#604) to another issue. Maybe @hjmjohnson can pitch in?

ITK's internal Eigen3 was also a somewhat recent addition, and was probably not tested as part of vcpkg before. Perhaps @phcerdan can provide advice or solution regarding that.

Neumann-A · 2019-03-08T21:57:54Z

@dzenanz dont use Eigen3 and the VC compiler please .... VS inefficient code with Eigen3

so now it is just fixing the portfile?

dzenanz · 2019-03-08T22:12:16Z

so now it is just fixing the portfile?

That could be. But I would still like @phcerdan and @hjmjohnson to give opinion about the two issues. These warnings might indicate a real problem in ITK's internal Eigen and VXL.

@hjmjohnson vcpkg should be working on Linux now, so you might give it a try.

phcerdan · 2019-03-08T22:21:15Z

The Eigen3 installation folder was changed recently: InsightSoftwareConsortium/ITK#567

So probably that's related to that change, and should be good? Not familiar with the portfile.

I didn't know the issues in the VC compiler with Eigen3 @Neumann-A ... maybe extra action has to be taken in ITK to avoid using Eigen3 in Windows.

Neumann-A · 2019-03-08T22:28:20Z

I didn't know the issues in the VC compiler with Eigen3 @Neumann-A ... maybe extra action has to be taken in ITK to avoid using Eigen3 in Windows.

It is just the Visual Studio Compiler, clang-cl would work fine. You could try #4609 in these cases

dzenanz · 2019-03-08T22:43:50Z

@phcerdan This is with yesterday's ITK, so that fix is already included.

Neumann-A · 2019-03-08T22:45:25Z

just add -DITK_USE_SYSTEM_EIGEN=ON in the portfile and put eigen into the control file as a dependency. should solve the eigen errors

Neumann-A · 2019-03-08T23:15:22Z

still installing targets:
need this to move the files:
vcpkg_fixup_cmake_targets(CONFIG_PATH lib/cmake/ITK-5.0/Modules TARGET_PATH share/itk/Modules)
FILE(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/lib/cmake)
FILE(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/lib/)

you probably dont want to install the normal eigen targets when ITK_USE_SYSTEM_EIGEN is used. All Other Modules can be found in share/itk/Modules. Probably dont use Eigen3_DIR_INSTALL when ITK_USE_SYSTEM_EIGEN is set

seems like an itk issue

phcerdan · 2019-03-08T23:25:19Z

It seems indeed, I own the blame! I will have a look tomorrow. Thanks @Neumann-A

Also added documentation about the logic having two Eigen3 targets, and a minimal CMake example for usage in external modules. Raised in: microsoft/vcpkg#5115 (comment)

phcerdan · 2019-03-09T23:38:42Z

Hopefully solved in InsightSoftwareConsortium/ITK#580. I removed the installation of any targets when ITK_USE_SYSTEM_EIGEN is ON.

Also added documentation about the logic having two Eigen3 targets, and a minimal CMake example for usage in external modules. Raised in: microsoft/vcpkg#5115 (comment)

dzenanz · 2019-03-11T20:22:55Z

@phcerdan 580 does not help. I still get:

$ ./vcpkg install itk[vtk]
The following packages will be built and installed:
    itk[core,vtk]:x64-windows-static
Starting package 1/1: itk:x64-windows-static
Building package itk[core,vtk]:x64-windows-static...
-- Downloading https://github.com/InsightSoftwareConsortium/ITK/archive/14b74af735aee8bfbe9d6a222835e1c2db1d8d88.tar.gz...
-- Extracting source C:/Dev/vcpkg/downloads/InsightSoftwareConsortium-ITK-14b74af735aee8bfbe9d6a222835e1c2db1d8d88.tar.gz
-- Using source at C:/Dev/vcpkg/buildtrees/itk/src/c2db1d8d88-deac65ac14
-- Configuring x64-windows-static-dbg
-- Configuring x64-windows-static-rel
-- Building x64-windows-static-dbg
-- Building x64-windows-static-rel
-- Performing post-build validation
The /lib/cmake folder should be merged with /debug/lib/cmake and moved to /share/itk/cmake.
The following cmake files were found outside /share/itk. Please place cmake files in /share/itk.

    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/Eigen3Config.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/Eigen3ConfigVersion.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/Eigen3Targets.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Config.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3ConfigVersion.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Targets.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/Eigen3Config.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/Eigen3ConfigVersion.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/Eigen3Targets.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Config.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3ConfigVersion.cmake
    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/lib/cmake/ITK-5.0/Modules/ITKInternalEigen3Targets.cmake

The /debug/lib/cmake folder should be merged with /lib/cmake into /share/itk
The following files are placed in
C:\Dev\vcpkg\packages\itk_x64-windows-static:

    C:/Dev/vcpkg/packages/itk_x64-windows-static/vcl_compiler_detection.h

Files cannot be present in those directories.

The following files are placed in
C:\Dev\vcpkg\packages\itk_x64-windows-static\debug:

    C:/Dev/vcpkg/packages/itk_x64-windows-static/debug/vcl_compiler_detection.h

Files cannot be present in those directories.

Found 5 error(s). Please correct the portfile:
    C:\Dev\vcpkg\ports\itk\portfile.cmake
-- Performing post-build validation done
Error: Building package itk:x64-windows-static failed with: POST_BUILD_CHECKS_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: itk:x64-windows-static
  Vcpkg version: 2018.11.23-nohash

Additionally, attach any relevant sections from the log files above.

Dzenan@Ryzenator MINGW64 /c/Dev/vcpkg (master)

I guess vcpkg complains about .cmake files in the build folder, not the install folder.

phcerdan · 2019-03-11T22:14:26Z

If you set ITK_USE_SYSTEM_EIGEN it should work.
However it seems there is an issue with the relative path introduced here: InsightSoftwareConsortium/ITK#567 (it was suggested here: InsightSoftwareConsortium/ITK#562)

dzenanz · 2019-03-11T22:49:34Z

Depending on eigen3 and adding -DITK_USE_SYSTEM_EIGEN=ON to portfile solves the Eigen-related messages.

ras0219-msft · 2019-03-29T03:24:05Z

As an update, this is the current status as of 4db83e4:

x64-windows	master	test	notes
netcdf-cxx4	Pass	Skip
netcdf-c	Pass	Fail	Regression

x64-windows-static	master	test	notes
netcdf-cxx4	Pass	Skip
netcdf-c	Pass	Fail	Regression

x64-osx	master	test	notes
highfive	Pass	Skip
itk	Fail	Skip
hdf5	Pass	Fail	Regression
vtk	Pass	Skip
kealib	Pass	Skip
alembic	Fail	Skip
netcdf-cxx4	Pass	Skip
matio	Fail	Skip
pcl	Pass	Skip
vtk-dicom	Pass	Skip
netcdf-c	Pass	Skip

arm64-windows had no regressions

x86-windows had no regressions

x64-linux	master	test	notes
highfive	Pass	Skip
itk	Fail	Skip
hdf5	Pass	Fail	Regression
vtk	Fail	Skip
kealib	Pass	Skip
alembic	Fail	Skip
netcdf-cxx4	Pass	Skip
matio	Fail	Skip
netcdf-c	Pass	Skip

x64-uwp had no regressions

arm-uwp had no regressions

I believe the netcdf issue is flakiness due to it writing to the source directory during configure; I've pushed d101837 to fix that. I've reproduced the hdf5 issue locally and it appears to be caused by CRLF line endings in the .zip file (trying out the .tar.gz to see if that fixes the problem).

Neumann-A · 2019-03-29T06:35:19Z

@ras0219-msft: Just rebase from master. HDF5 has been switched to tar.gz in 49f59fd because I also had problems with strange line breaks in the zip.

sry for wrong mention before

Neumann-A · 2019-03-29T06:40:03Z

@ras0219-msft: and looking at the changes this pull request should either be closed or resubmitted with actually adressing the original issues. (Probably just updating the portfile of ITK and nothing else)
(Because the issues seems to be solved upstream in the ITK repo)

dzenanz · 2019-03-29T14:24:27Z

Rebasing just the ITK-related changes on top of current master sounds good, as it has HDF5-1.10.5. Do you want me to do it, or will somebody else do it?

ras0219-msft · 2019-03-29T23:00:57Z

I'd like to keep the netcdf-c changes as well, but if you'd like to rebase it that would be great!

…rsion.

…Switch to tar.gz to prevent CRLF line endings.

ras0219-msft · 2019-04-03T03:35:56Z

Awesome -- thanks for the PR!

dzenanz mentioned this pull request Jan 9, 2019

Update HDF5 to 1.10.2 or later #5116

Closed

thewtex approved these changes Jan 13, 2019

View reviewed changes

dzenanz mentioned this pull request Jan 17, 2019

Update from 3.0 to 3.1 breaks vcpkg build google/double-conversion#85

Closed

ras0219-msft self-assigned this Jan 17, 2019

MarkIanHolland mentioned this pull request Feb 21, 2019

[Port bug]Build itk in x86-windows failed. #5396

Closed

dzenanz force-pushed the master branch from dab6104 to b4ff426 Compare March 8, 2019 15:38

dzenanz mentioned this pull request Mar 8, 2019

Use find_package and target_link_libraries to include system double conversion and properly include double-conversion InsightSoftwareConsortium/ITK#579

Closed

dzenanz force-pushed the master branch from b4ff426 to 3a0173d Compare March 8, 2019 21:25

phcerdan mentioned this pull request Mar 9, 2019

BUG: Do no install any Eigen3 targets if ITK_USE_SYSTEM_EIGEN=ON InsightSoftwareConsortium/ITK#580

Merged

tetsuh mentioned this pull request Mar 10, 2019

ITK build failed by broken VTK dependency #5614

Closed

phcerdan mentioned this pull request Mar 11, 2019

Request to run the benchmark before and after introducing Eigen3 in Windows with VS compiler InsightSoftwareConsortium/ITKPerformanceBenchmarking#73

Open

dzenanz force-pushed the master branch 3 times, most recently from c077afd to 956dd66 Compare March 11, 2019 21:43

dzenanz and others added 8 commits March 31, 2019 10:44

Using newer version of ITK which fixes double-conversion problem

fbc94c1

Minor style update of ITK portfile

5fcf52f

Using newer version of ITK which fixes double-conversion problem

cd3097f

[itk] Improve version string

02a2ef8

[itk][hdf5] Update ITK commit. Depend on eigen3. Bump hdf5 control ve…

0dc5006

…rsion.

[hdf5] Update CONTROL

580302f

[netcdf-c] Disable parallel configure due to writes to source directory

b120686

[hdf5] Disable parallel configure due to writes to source directory. …

82c42c8

…Switch to tar.gz to prevent CRLF line endings.

dzenanz force-pushed the master branch from e144602 to 82c42c8 Compare March 31, 2019 16:03

ras0219-msft merged commit 641e1cd into microsoft:master Apr 3, 2019

dzenanz mentioned this pull request Apr 9, 2019

ITK install fails #3115

Closed

Conversation

dzenanz commented Jan 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PhoebeHui commented Mar 6, 2019

Uh oh!

dzenanz commented Mar 6, 2019

Uh oh!

PhoebeHui commented Mar 7, 2019

Uh oh!

Neumann-A commented Mar 8, 2019

Uh oh!

dzenanz commented Mar 8, 2019

Uh oh!

Neumann-A commented Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dzenanz commented Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neumann-A commented Mar 8, 2019

Uh oh!

dzenanz commented Mar 8, 2019

Uh oh!

phcerdan commented Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neumann-A commented Mar 8, 2019

Uh oh!

dzenanz commented Mar 8, 2019

Uh oh!

Neumann-A commented Mar 8, 2019

Uh oh!

Neumann-A commented Mar 8, 2019

Uh oh!

phcerdan commented Mar 8, 2019

Uh oh!

phcerdan commented Mar 9, 2019

Uh oh!

dzenanz commented Mar 11, 2019

Uh oh!

phcerdan commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dzenanz commented Mar 11, 2019

Uh oh!

ras0219-msft commented Mar 29, 2019

Uh oh!

Neumann-A commented Mar 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neumann-A commented Mar 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dzenanz commented Mar 29, 2019

Uh oh!

ras0219-msft commented Mar 29, 2019

Uh oh!

ras0219-msft commented Apr 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dzenanz commented Jan 9, 2019 •

edited

Loading

Neumann-A commented Mar 8, 2019 •

edited

Loading

dzenanz commented Mar 8, 2019 •

edited

Loading

phcerdan commented Mar 8, 2019 •

edited

Loading

phcerdan commented Mar 11, 2019 •

edited

Loading

Neumann-A commented Mar 29, 2019 •

edited

Loading

Neumann-A commented Mar 29, 2019 •

edited

Loading