Skip to content

Update boost-iostreams to the same style as the other Boost ports.#5042

Closed
chrullrich wants to merge 2 commits intomicrosoft:masterfrom
chrullrich:boost-iostreams-4468
Closed

Update boost-iostreams to the same style as the other Boost ports.#5042
chrullrich wants to merge 2 commits intomicrosoft:masterfrom
chrullrich:boost-iostreams-4468

Conversation

@chrullrich
Copy link
Contributor

Fixes #4468. I think.

@Rastaban Rastaban self-assigned this Feb 27, 2019
@Rastaban
Copy link
Contributor

I see a failure in the cartographer port on x64-windows and x86-windows. It has a dependency on boost-iostreams.

@PhoebeHui
Copy link
Contributor

@Rastaban
Copy link
Contributor

@ras0219-msft, you mentioned the other day that there was somthing about boost-iostreams that made it unique so you added the CMakeLists.txt. Could you remind me what that was? It was added for boost 1.67 and I am wondering if it still applies to 1.69 and also if it is related to the cartogropher port failures in this PR.

@ras0219-msft
Copy link
Contributor

@chrullrich Thanks for the PR; the reason we have a separate style for this library compared to the other boost libraries is because:

  1. The iostreams build is relatively simple (doesn't have complex assembly code or otherwise)
  2. .. except for dependencies. We were unable to get boost build to reliably detect the dependencies, whereas it is trivial for CMake to do so. Therefore, rewriting the buildsystem in CMake is the best option available.

@chrullrich chrullrich deleted the boost-iostreams-4468 branch June 21, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boost 1.68.0 dll names

4 participants