-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[wxwidgets] update to 3.3.2 #50288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
toge
wants to merge
2
commits into
microsoft:master
Choose a base branch
from
toge:wxwidgets-3.3.2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[wxwidgets] update to 3.3.2 #50288
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,42 @@ | ||
| diff --git a/build/cmake/init.cmake b/build/cmake/init.cmake | ||
| index f044d22d4d..a78b9aa1e9 100644 | ||
| index 418fe12..0726ea2 100644 | ||
| --- a/build/cmake/init.cmake | ||
| +++ b/build/cmake/init.cmake | ||
| @@ -200,12 +200,12 @@ endif() | ||
|
|
||
| @@ -201,11 +201,8 @@ endif() | ||
| wx_get_install_dir(include) | ||
| if(WIN32_MSVC_NAMING) | ||
| if(wxBUILD_SHARED) | ||
| - set(lib_suffix "_dll") | ||
| + # set(lib_suffix "_dll") | ||
| else() | ||
| - set(lib_suffix "_lib") | ||
| + # set(lib_suffix "_lib") | ||
| endif() | ||
|
|
||
| - set(wxPLATFORM_LIB_DIR "${wxCOMPILER_PREFIX}${wxARCH_SUFFIX}${lib_suffix}") | ||
| + # set(wxPLATFORM_LIB_DIR "${wxCOMPILER_PREFIX}${wxARCH_SUFFIX}${lib_suffix}") | ||
|
|
||
| # Generator expression to not create different Debug and Release directories | ||
| set(GEN_EXPR_DIR "$<1:/>") | ||
| set(wxINSTALL_INCLUDE_DIR "${include_dir}") | ||
| else() | ||
| wx_get_flavour(lib_flavour "-") | ||
| diff --git a/build/cmake/install.cmake b/build/cmake/install.cmake | ||
| index a373983043..2e1ace7bf9 100644 | ||
| index 88591a8..14f88cb 100644 | ||
| --- a/build/cmake/install.cmake | ||
| +++ b/build/cmake/install.cmake | ||
| @@ -63,7 +63,7 @@ else() | ||
|
|
||
| install(DIRECTORY DESTINATION "bin") | ||
| @@ -68,7 +68,7 @@ else() | ||
| wx_get_install_platform_dir(runtime) | ||
| install(DIRECTORY DESTINATION "${runtime_dir}") | ||
| install(CODE "execute_process( \ | ||
| - COMMAND ${CMAKE_COMMAND} -E create_symlink \ | ||
| + COMMAND ${CMAKE_COMMAND} -E copy \ | ||
| \"\$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/lib/wx/config/${wxBUILD_FILE_ID}\" \ | ||
| \"\$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/bin/wx-config\" \ | ||
| \"${CMAKE_INSTALL_PREFIX}/${library_dir}/wx/config/${wxBUILD_FILE_ID}\" \ | ||
| \"\$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/${runtime_dir}/wx-config\" \ | ||
| )" | ||
| diff --git a/build/cmake/utils/CMakeLists.txt b/build/cmake/utils/CMakeLists.txt | ||
| index 15f4339ef9..f93849e025 100644 | ||
| index 608351a..d8110f9 100644 | ||
| --- a/build/cmake/utils/CMakeLists.txt | ||
| +++ b/build/cmake/utils/CMakeLists.txt | ||
| @@ -39,7 +39,7 @@ if(wxUSE_XRC) | ||
| @@ -40,7 +40,7 @@ if(wxUSE_XRC) | ||
|
|
||
| # Don't use wx_install() here to preserve escaping. | ||
| install(CODE "execute_process( \ | ||
| - COMMAND ${CMAKE_COMMAND} -E create_symlink \ | ||
| + COMMAND ${CMAKE_COMMAND} -E copy \ | ||
| \"\$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/bin/${wxrc_output_name}${EXE_SUFFIX}\" \ | ||
| \"\$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/bin/wxrc${EXE_SUFFIX}\" \ | ||
| \"${CMAKE_INSTALL_PREFIX}/${runtime_dir}/${wxrc_output_name}${EXE_SUFFIX}\" \ | ||
| \"\$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/${runtime_dir}/wxrc${EXE_SUFFIX}\" \ | ||
| )" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really need to be enabled by default?
Please see the discussion here: #49620